Skip to content

Commit 2bb4a51

Browse files
author
Radu M
committed
Remove kubectl wait from the cluster creation
Signed-off-by: Radu M <root@radu.sh>
1 parent 01d0ba3 commit 2bb4a51

3 files changed

Lines changed: 9 additions & 27 deletions

File tree

README.md

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ jobs:
1414
steps:
1515
- uses: actions/checkout@master
1616
- uses: engineerd/setup-kind@v0.3.0
17-
with:
18-
version: <kind-version>
19-
<other input>: <other-value>
2017
- name: Testing
2118
run: |
2219
export KUBECONFIG="$(kind get kubeconfig-path)"
@@ -30,23 +27,11 @@ jobs:
3027
The following arguments can be configured on the job using the `with` keyword (see example above).
3128
Currently, possible inputs are all the flags for `kind cluster create`, with the additional version, which sets the Kind version to downloadm and `skipClusterCreation`, which when present, skips creating the cluster (the Kind tools is configured in the path).
3229

33-
```
34-
inputs:
35-
version:
36-
description: "Version of Kind to use (default v0.5.1)"
37-
default: "v0.5.1"
38-
config:
39-
description: "Path (relative to the root of the repository) to a kind config file"
40-
image:
41-
description: "Node Docker image to use for booting the cluster"
42-
name:
43-
description: "Cluster context name (default kind)"
44-
default: "kind"
45-
wait:
46-
description: "Wait for control plane node to be ready (default 300s)"
47-
default: "300s"
48-
49-
skipClusterCreation:
50-
description: "If true, the action will not create a cluster, just acquire the tools"
51-
default: false
52-
```
30+
Optional inputs:
31+
32+
- `version`: version of Kind to use (default `"v0.5.1"`).
33+
- `config`: path (relative to the root of the repository) to a kind config file. If omitted, a default 1-node cluster will be created.
34+
- `image`: node Docker image to use for booting the cluster.
35+
- `name`: cluster context name (default `"kind"`)
36+
- `wait`: wait for control plane node to be ready (default `"300s"`)
37+
- `skipClusterCreation`: if `"true"`, the action will not create a cluster, just acquire the tools

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ inputs:
1818

1919
skipClusterCreation:
2020
description: "If true, the action will not create a cluster, just acquire the tools"
21-
default: false
21+
default: "false"
2222
runs:
2323
using: "node12"
2424
main: "lib/main.js"

src/kind.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ export class KindConfig {
5454

5555
console.log("Executing kind with args " + this.getCommand());
5656
await exec.exec("kind", this.getCommand());
57-
58-
// extra step for waiting on pods to be ready
59-
await exec.exec("kubectl wait --for=condition=Ready pods --all --namespace kube-system");
6057
}
6158
}
6259

0 commit comments

Comments
 (0)