Skip to content

Commit 6622553

Browse files
Cleanup Request method parameter. (#3378)
1 parent 12be5c4 commit 6622553

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This release introduces an `httpx.SSLContext()` class and `ssl_context` paramete
1717
* Review URL percent escape sets, based on WHATWG spec. (#3371, #3373)
1818
* Ensure `certifi` and `httpcore` are only imported if required. (#3377)
1919
* Treat `socks5h` as a valid proxy scheme. (#3178)
20+
* Cleanup `Request()` method signature in line with `client.request()` and `httpx.request()`. (#3378)
2021

2122
## 0.27.2 (27th August, 2024)
2223

httpx/_models.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ def __repr__(self) -> str:
310310
class Request:
311311
def __init__(
312312
self,
313-
method: str | bytes,
313+
method: str,
314314
url: URL | str,
315315
*,
316316
params: QueryParamTypes | None = None,
@@ -323,11 +323,7 @@ def __init__(
323323
stream: SyncByteStream | AsyncByteStream | None = None,
324324
extensions: RequestExtensions | None = None,
325325
) -> None:
326-
self.method = (
327-
method.decode("ascii").upper()
328-
if isinstance(method, bytes)
329-
else method.upper()
330-
)
326+
self.method = method.upper()
331327
self.url = URL(url) if params is None else URL(url, params=params)
332328
self.headers = Headers(headers)
333329
self.extensions = {} if extensions is None else extensions

0 commit comments

Comments
 (0)