Merge pull request #1467 from emberjs/fix-type-imports

Fix import type via upgrading @tsconfig/ember

Author: NullVoxPopuli

.github/workflows/ci-build.yml

@@ -37,7 +37,13 @@ jobs:
           cache: pnpm
       - name: Install Dependencies
         run: pnpm install 
+      - name: Build addon
+        working-directory: addon
+        run: pnpm build
       - run: pnpm test
+      - name: own types 
+        working-directory: addon
+        run: pnpm tsc --noEmit 
 
   floating:
     name: "Floating Dependencies"
@@ -52,8 +58,14 @@ jobs:
           cache: pnpm
       - name: Install Dependencies
         run: pnpm install --no-lockfile
+      - name: Build addon
+        working-directory: addon
+        run: pnpm build
       - name: Run Tests
         run: pnpm test
+      - name: own types 
+        working-directory: addon
+        run: pnpm tsc --noEmit 
 
   try-scenarios:
     timeout-minutes: 10
@@ -88,6 +100,9 @@ jobs:
           cache: pnpm
       - name: Install Dependencies
         run: pnpm install 
+      - name: Build addon
+        working-directory: addon
+        run: pnpm build
       - name: test
         working-directory: addon
         run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
@@ -121,9 +136,12 @@ jobs:
           cache: pnpm
       - name: Install Dependencies
         run: pnpm install 
-      - name: install TS version
+      - name: Build types for addon
         working-directory: addon
+        run: pnpm build
+      - name: install TS version
+        working-directory: type-tests
         run: pnpm add --save-dev typescript@${{matrix.ts-version}}
-      - name: test types
-        working-directory: addon
-        run: pnpm lint:ts
+      - name: public types
+        working-directory: type-tests
+        run: pnpm test 

addon/addon-test-support/@ember/test-helpers/-internal/build-registry.ts

@@ -6,7 +6,7 @@ import EmberObject from '@ember/object';
 import require, { has } from 'require';
 import Ember from 'ember';
 
-import { FullName } from '@ember/owner';
+import type { FullName } from '@ember/owner';
 
 // These shenanigans work around the fact that the import locations are not
 // public API and are not stable, so we jump through hoops to get the right

addon/addon-test-support/@ember/test-helpers/-internal/debug-info.ts

@@ -2,9 +2,12 @@
 // "provides" this public API, but does not for earlier versions. As a result,
 // this type will be `any`.
 import { _backburner } from '@ember/runloop';
-import { DebugInfo as BackburnerDebugInfo } from '@ember/runloop/-private/backburner';
-import { DebugInfoHelper, debugInfoHelpers } from './debug-info-helpers';
-import { getPendingWaiterState, PendingWaiterState } from '@ember/test-waiters';
+import type { DebugInfo as BackburnerDebugInfo } from '@ember/runloop/-private/backburner';
+import { type DebugInfoHelper, debugInfoHelpers } from './debug-info-helpers';
+import {
+  getPendingWaiterState,
+  type PendingWaiterState,
+} from '@ember/test-waiters';
 
 const PENDING_AJAX_REQUESTS = 'Pending AJAX requests';
 const PENDING_TEST_WAITERS = 'Pending test waiters';

addon/addon-test-support/@ember/test-helpers/-internal/deprecations.ts

@@ -1,4 +1,4 @@
-import { BaseContext } from '../setup-context';
+import type { BaseContext } from '../setup-context';
 import { registerDeprecationHandler } from '@ember/debug';
 import isPromise from './is-promise';
 

addon/addon-test-support/@ember/test-helpers/-internal/warnings.ts

@@ -1,4 +1,4 @@
-import { BaseContext } from '../setup-context';
+import type { BaseContext } from '../setup-context';
 import { registerWarnHandler } from '@ember/debug';
 import isPromise from './is-promise';
 

addon/addon-test-support/@ember/test-helpers/build-owner.ts

@@ -2,8 +2,8 @@ import Application from '@ember/application';
 import type { Resolver } from '@ember/owner';
 
 import legacyBuildRegistry from './-internal/build-registry';
-import EmberOwner from '@ember/owner';
-import { SimpleElement } from '@simple-dom/interface';
+import type EmberOwner from '@ember/owner';
+import type { SimpleElement } from '@simple-dom/interface';
 
 export interface Owner extends EmberOwner {
   _emberTestHelpersMockOwner?: boolean;

addon/addon-test-support/@ember/test-helpers/dom/-get-description.ts

@@ -1,5 +1,5 @@
 import { isDescriptor, lookupDescriptorData } from 'dom-element-descriptors';
-import type Target from './-target';
+import type { Target } from './-target';
 
 /**
   Used internally by the DOM interaction helpers to get a description of a

addon/addon-test-support/@ember/test-helpers/dom/-get-element.ts

@@ -1,5 +1,5 @@
 import getRootElement from './get-root-element';
-import Target, { isDocument, isElement } from './-target';
+import { type Target, isDocument, isElement } from './-target';
 import {
   type IDOMElementDescriptor,
   lookupDescriptorData,

addon/addon-test-support/@ember/test-helpers/dom/-get-window-or-element.ts

@@ -1,5 +1,5 @@
 import getElement from './-get-element';
-import Target, { isWindow } from './-target';
+import { type Target, isWindow } from './-target';
 
 /**
   Used internally by the DOM interaction helpers to find either window or an element.

addon/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.ts

@@ -1,4 +1,4 @@
-import { FormControl } from './-is-form-control';
+import type { FormControl } from './-is-form-control';
 
 // ref: https://html.spec.whatwg.org/multipage/input.html#concept-input-apply
 const constrainedInputTypes = [