Successful build

Author: NullVoxPopuli

addon/.eslintrc.cjs

@@ -37,7 +37,13 @@ module.exports = {
       rules: {
         // require relative imports use full extensions
         'import/extensions': ['error', 'always', { ignorePackages: true }],
-        // Add any custom rules here
+        // We break a lot of rules with types
+        // (public types do not always exist for the things we need to import)
+        '@typescript-eslint/ban-ts-comment': 'off',
+        '@typescript-eslint/no-explicit-any': 'off',
+        // We access the _routerMicrolib
+        // and router:main
+        'ember/no-private-routing-service': 'off',
       },
     },
     {

addon/.template-lintrc.cjs

@@ -1,6 +1,7 @@
 import { babel } from '@rollup/plugin-babel';
 import copy from 'rollup-plugin-copy';
 import { Addon } from '@embroider/addon-dev/rollup';
+import { execaCommand } from "execa";
 
 const addon = new Addon({
   srcDir: 'src',
@@ -68,5 +69,12 @@ export default {
         { src: '../LICENSE.md', dest: '.' },
       ],
     }),
+    {
+      name: 'Build declarations',
+      closeBundle: async () => {
+        console.log("Building types");
+        await execaCommand(`pnpm glint --declaration`, { stdio: "inherit" });
+      }
+    }
   ],
 };

addon/rollup.config.mjs

@@ -13,7 +13,7 @@ import type { FullName } from '@ember/owner';
 import {
   ContainerProxyMixin,
   RegistryProxyMixin,
-} from './-owner-mixin-imports';
+} from './-owner-mixin-imports.ts';
 
 /**
  * Adds methods that are normally only on registry to the container. This is largely to support the legacy APIs
@@ -23,7 +23,7 @@ import {
  * @param {Object} container  the container to modify
  */
 function exposeRegistryMethodsWithoutDeprecations(container: any) {
-  let methods = [
+  const methods = [
     'register',
     'unregister',
     'resolve',
@@ -38,7 +38,7 @@ function exposeRegistryMethodsWithoutDeprecations(container: any) {
   ];
 
   for (let i = 0, l = methods.length; i < l; i++) {
-    let methodName = methods[i];
+    const methodName = methods[i];
 
     if (methodName && methodName in container) {
       const knownMethod = methodName;
@@ -87,7 +87,7 @@ const Owner = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixin, {
  * @returns {Object} owner, container, registry
  */
 export default function buildRegistry(resolver: Resolver) {
-  let namespace = new Application();
+  const namespace = new Application();
   // @ts-ignore: this is actually the correcct type, but there was a typo in
   // Ember's docs for many years which meant that there was a matching problem
   // in the types for Ember's definition of `Engine`. Once we require at least
@@ -99,13 +99,13 @@ export default function buildRegistry(resolver: Resolver) {
   };
 
   // @ts-ignore: this is private API.
-  let fallbackRegistry = Application.buildRegistry(namespace);
+  const fallbackRegistry = Application.buildRegistry(namespace);
   // TODO: only do this on Ember < 3.13
   // @ts-ignore: this is private API.
   fallbackRegistry.register('component-lookup:main', Ember.ComponentLookup);
 
   // @ts-ignore: this is private API.
-  let registry = new Ember.Registry({
+  const registry = new Ember.Registry({
     fallback: fallbackRegistry,
   });
 
@@ -123,7 +123,7 @@ export default function buildRegistry(resolver: Resolver) {
   // @ts-ignore: this is private API.
   registry.describe = fallbackRegistry.describe;
 
-  let owner = Owner.create({
+  const owner = Owner.create({
     // @ts-ignore -- we do not have type safety for `Object.extend` so the type
     // of `Owner` here is just `EmberObject`, but we *do* constrain it to allow
     // only types from the actual class, so these fields are not accepted.
@@ -140,7 +140,7 @@ export default function buildRegistry(resolver: Resolver) {
   }) as unknown as Owner;
 
   // @ts-ignore: this is private API.
-  let container = registry.container({ owner: owner });
+  const container = registry.container({ owner: owner });
   // @ts-ignore: this is private API.
   owner.__container__ = container;
 

addon/src/-internal/build-registry.ts

@@ -3,7 +3,10 @@
 // this type will be `any`.
 import { _backburner } from '@ember/runloop';
 import type { DebugInfo as BackburnerDebugInfo } from '@ember/runloop/-private/backburner';
-import { type DebugInfoHelper, debugInfoHelpers } from './debug-info-helpers';
+import {
+  type DebugInfoHelper,
+  debugInfoHelpers,
+} from './debug-info-helpers.ts';
 import {
   getPendingWaiterState,
   type PendingWaiterState,
@@ -89,7 +92,7 @@ export class TestDebugInfo implements DebugInfo {
 
   constructor(
     settledState: SettledState,
-    debugInfo: MaybeDebugInfo = getDebugInfo()
+    debugInfo: MaybeDebugInfo = getDebugInfo(),
   ) {
     this._settledState = settledState;
     this._debugInfo = debugInfo;
@@ -107,7 +110,7 @@ export class TestDebugInfo implements DebugInfo {
           this._settledState.hasPendingTimers &&
           this._summaryInfo.pendingTimersCount > 0;
         this._summaryInfo.pendingTimersStackTraces = this._debugInfo.timers.map(
-          (timer) => timer.stack
+          (timer) => timer.stack,
         );
 
         this._summaryInfo.pendingScheduledQueueItemCount =
@@ -135,7 +138,8 @@ export class TestDebugInfo implements DebugInfo {
                 // also be compatible with the version where Ember *does* supply
                 // the types correctly.
                 (queueItems as Array<{ stack: string }> | undefined)?.forEach(
-                  (queueItem) => queueItem.stack && stacks.push(queueItem.stack)
+                  (queueItem) =>
+                    queueItem.stack && stacks.push(queueItem.stack),
                 );
               });
               return stacks;
@@ -177,14 +181,14 @@ export class TestDebugInfo implements DebugInfo {
               _console.log(
                 `${debugInfo.label ? debugInfo.label : 'stack'}: ${
                   debugInfo.stack
-                }`
+                }`,
               );
             });
             _console.groupEnd();
           } else {
             _console.log(waiterName);
           }
-        }
+        },
       );
     }
 
@@ -201,7 +205,7 @@ export class TestDebugInfo implements DebugInfo {
       summary.pendingScheduledQueueItemStackTraces.forEach(
         (scheduleQueueItemStack) => {
           _console.log(scheduleQueueItemStack);
-        }
+        },
       );
 
       _console.groupEnd();

addon/src/-internal/debug-info.ts

@@ -1,6 +1,6 @@
 import type { BaseContext } from '../setup-context';
 import { registerDeprecationHandler } from '@ember/debug';
-import isPromise from './is-promise';
+import isPromise from './is-promise.ts';
 
 export interface DeprecationOptions {
   id: string;
@@ -27,11 +27,11 @@ const DEPRECATIONS = new WeakMap<BaseContext, Array<DeprecationFailure>>();
  * @return {Array<DeprecationFailure>} the Deprecation Failures associated with the corresponding BaseContext;
  */
 export function getDeprecationsForContext(
-  context: BaseContext
+  context: BaseContext,
 ): Array<DeprecationFailure> {
   if (!context) {
     throw new TypeError(
-      `[@ember/test-helpers] could not get deprecations for an invalid test context: '${context}'`
+      `[@ember/test-helpers] could not get deprecations for an invalid test context: '${context}'`,
     );
   }
 
@@ -58,11 +58,11 @@ export function getDeprecationsForContext(
  */
 export function getDeprecationsDuringCallbackForContext(
   context: BaseContext,
-  callback: () => void
+  callback: () => void,
 ): Array<DeprecationFailure> | Promise<Array<DeprecationFailure>> {
   if (!context) {
     throw new TypeError(
-      `[@ember/test-helpers] could not get deprecations for an invalid test context: '${context}'`
+      `[@ember/test-helpers] could not get deprecations for an invalid test context: '${context}'`,
     );
   }
 

addon/src/-internal/deprecations.ts

@@ -1,6 +1,6 @@
 import type { BaseContext } from '../setup-context';
 import { registerWarnHandler } from '@ember/debug';
-import isPromise from './is-promise';
+import isPromise from './is-promise.ts';
 
 export interface WarningOptions {
   id?: string;
@@ -26,7 +26,7 @@ const WARNINGS = new WeakMap<BaseContext, Array<Warning>>();
 export function getWarningsForContext(context: BaseContext): Array<Warning> {
   if (!context) {
     throw new TypeError(
-      `[@ember/test-helpers] could not get warnings for an invalid test context: '${context}'`
+      `[@ember/test-helpers] could not get warnings for an invalid test context: '${context}'`,
     );
   }
 
@@ -53,11 +53,11 @@ export function getWarningsForContext(context: BaseContext): Array<Warning> {
  */
 export function getWarningsDuringCallbackForContext(
   context: BaseContext,
-  callback: () => void
+  callback: () => void,
 ): Array<Warning> | Promise<Array<Warning>> {
   if (!context) {
     throw new TypeError(
-      `[@ember/test-helpers] could not get warnings for an invalid test context: '${context}'`
+      `[@ember/test-helpers] could not get warnings for an invalid test context: '${context}'`,
     );
   }
 
@@ -80,7 +80,7 @@ export function getWarningsDuringCallbackForContext(
 // * enable a debuggger when a warning by a specific name is encountered via: `/tests/index.html?debugWarnings=some-other-thing` when the
 if (typeof URLSearchParams !== 'undefined') {
   const queryParams = new URLSearchParams(
-    document.location.search.substring(1)
+    document.location.search.substring(1),
   );
   const disabledWarnings = queryParams.get('disabledWarnings');
   const debugWarnings = queryParams.get('debugWarnings');

addon/src/-internal/warnings.ts

@@ -1,6 +1,6 @@
 /* globals Promise */
 
-import isFormControl from './dom/-is-form-control';
+import isFormControl from './dom/-is-form-control.ts';
 
 export const nextTick = (cb: () => void) => Promise.resolve().then(cb);
 export const futureTick = setTimeout;
@@ -15,7 +15,7 @@ export const futureTick = setTimeout;
  @param {string} property the property on the object that contains the destroyable array
 */
 export function runDestroyablesFor(object: any, property: string): void {
-  let destroyables = object[property];
+  const destroyables = object[property];
 
   if (!destroyables) {
     return;
@@ -47,7 +47,7 @@ export function isNumeric(n: string): boolean {
   @returns {boolean} `true` when the element is visible, `false` otherwise
 */
 export function isVisible(element: Element): boolean {
-  let styles = window.getComputedStyle(element);
+  const styles = window.getComputedStyle(element);
   return styles.display !== 'none' && styles.visibility !== 'hidden';
 }
 

addon/src/-utils.ts

@@ -1,6 +1,6 @@
 import Application from '@ember/application';
 
-import { getResolver, setResolver } from './resolver';
+import { getResolver, setResolver } from './resolver.ts';
 
 let __application__: Application | undefined;
 
@@ -17,8 +17,8 @@ export function setApplication(application: Application): void {
   __application__ = application;
 
   if (!getResolver()) {
-    let Resolver = (application as any).Resolver;
-    let resolver = Resolver.create({ namespace: application });
+    const Resolver = (application as any).Resolver;
+    const resolver = Resolver.create({ namespace: application });
 
     setResolver(resolver);
   }

addon/src/application.ts

@@ -1,7 +1,7 @@
 import Application from '@ember/application';
 import type { Resolver } from '@ember/owner';
 
-import legacyBuildRegistry from './-internal/build-registry';
+import legacyBuildRegistry from './-internal/build-registry.ts';
 import type EmberOwner from '@ember/owner';
 import type { SimpleElement } from '@simple-dom/interface';
 
@@ -39,7 +39,7 @@ export interface Owner extends EmberOwner {
 */
 export default function buildOwner(
   application: Application | undefined | null,
-  resolver: Resolver | undefined | null
+  resolver: Resolver | undefined | null,
 ): Promise<Owner> {
   if (application) {
     // @ts-ignore: this type is correct and will check against Ember 4.12 or 5.1
@@ -51,7 +51,7 @@ export default function buildOwner(
 
   if (!resolver) {
     throw new Error(
-      'You must set up the ember-test-helpers environment with either `setResolver` or `setApplication` before running any tests.'
+      'You must set up the ember-test-helpers environment with either `setResolver` or `setApplication` before running any tests.',
     );
   }