Re-enable embroider-optimized

Author: NullVoxPopuli

.github/workflows/ci-build.yml

@@ -105,7 +105,7 @@ jobs:
           - ember-canary
           - ember-default
           - embroider-safe
-          # - embroider-optimized # see comments in ember-try.js
+          - embroider-optimized 
 
     steps:
       - uses: actions/checkout@v4

test-app/config/ember-try.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');
-const { embroiderSafe } = require('@embroider/test-setup');
+const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
 const latestVersion = require('latest-version');
 
 module.exports = async function () {
@@ -122,19 +122,7 @@ module.exports = async function () {
         },
       },
       embroiderSafe(),
-      // disable embroider optimized test scenarios, as the dynamism these
-      // tests use is not compatible with embroider we are still exploring
-      // appropriate paths forward.
-      //
-      // Steps to re-enable:
-      //
-      // 1. have a strategy to make this work, import from '@embroider/test-setup'
-      // 2. uncomment the next line
-      // embroiderOptimized();
-      //
-      // 3. add "embroider-optimized" to .github/workflows/ci-build.yml's
-      //    ember-try-scenario list.
-      //
+      embroiderOptimized(),
     ],
   };
 };

test-app/ember-cli-build.js

@@ -7,5 +7,6 @@ module.exports = function (defaults) {
     // Add options here
   });
 
-  return app.toTree();
+  const { maybeEmbroider } = require('@embroider/test-setup');
+  return maybeEmbroider(app);
 };