Skip to content

Commit 99a5f20

Browse files
committed
Update lints
1 parent b36fd5d commit 99a5f20

7 files changed

Lines changed: 436 additions & 159 deletions

File tree

addon/src/-internal/debug-info.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export class TestDebugInfo implements DebugInfo {
233233
}
234234
}
235235

236-
// eslint-disable-next-line require-jsdoc
236+
// eslint-disable-next-line require-jsdoc, @typescript-eslint/no-empty-object-type
237237
function isNotNullable<T extends {}>(value: T | null | undefined): value is T {
238238
return value != null;
239239
}

addon/src/-tuple.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
12
export type Lit = string | number | boolean | undefined | null | void | {};
23

34
// eslint-disable-next-line require-jsdoc

addon/src/dom/fire-event.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const MOUSE_EVENT_CONSTRUCTOR = (() => {
1313
try {
1414
new MouseEvent('test');
1515
return true;
16-
} catch (e) {
16+
} catch {
1717
return false;
1818
}
1919
})();
@@ -197,7 +197,7 @@ function buildMouseEvent(type: MouseEventType, options: any = {}) {
197197
eventOpts.button,
198198
eventOpts.relatedTarget,
199199
);
200-
} catch (e) {
200+
} catch {
201201
event = buildBasicEvent(type, options);
202202
}
203203
}
@@ -239,22 +239,22 @@ export function _buildKeyboardEvent(
239239
});
240240

241241
return event;
242-
} catch (e) {
242+
} catch {
243243
// left intentionally blank
244244
}
245245

246246
try {
247247
event = document.createEvent('KeyboardEvents');
248248
eventMethodName = 'initKeyboardEvent';
249-
} catch (e) {
249+
} catch {
250250
// left intentionally blank
251251
}
252252

253253
if (!event) {
254254
try {
255255
event = document.createEvent('KeyEvents');
256256
eventMethodName = 'initKeyEvent';
257-
} catch (e) {
257+
} catch {
258258
// left intentionally blank
259259
}
260260
}

addon/src/settled.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ export function _setupAJAXHooks() {
167167
.on('ajaxComplete', decrementAjaxPendingRequests);
168168
}
169169

170+
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
170171
let _internalCheckWaiters: Function;
171172

172173
const loader = (Ember as any).__loader;
@@ -187,6 +188,7 @@ if (loader.registry['ember-testing/test/waiters']) {
187188
@returns {boolean} true if waiters are still pending
188189
*/
189190
function checkWaiters() {
191+
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
190192
type Waiter = [any, Function];
191193
const EmberTest = Ember.Test as any as { waiters: Array<Waiter> };
192194

test-app/.eslintrc.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ module.exports = {
2222
env: {
2323
browser: true,
2424
},
25-
rules: {},
25+
rules: {
26+
'ember/no-runloop': 'off',
27+
},
2628
overrides: [
2729
// node files
2830
{

test-app/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
"ember-try": "^3.0.0",
5959
"eslint": "^8.37.0",
6060
"eslint-config-prettier": "^8.8.0",
61-
"eslint-plugin-ember": "^11.5.0",
62-
"eslint-plugin-n": "^15.7.0",
61+
"eslint-plugin-ember": "^12.2.0",
62+
"eslint-plugin-n": "^17.10.2",
6363
"eslint-plugin-prettier": "^4.2.1",
6464
"eslint-plugin-qunit": "^7.3.4",
6565
"latest-version": "^5.0.0",

0 commit comments

Comments
 (0)