Fix CI by fixing TS dependencies *and* types

CI for Embroider Safe has been failing for a bit because we are using
new TS versions and need an updated combination of Babel and related
compilation deps. Accordingly:

- Bump to latest versions of all compilation dependencies, including:
    - `ember-cli-babel`
    - `ember-cli-htmlbars`
    - `@babel/*`
    - `@embroider/*`

- Fix type errors exposed by running `tsc` with the changes in place.

- Remove the type tests from the normal build graph.

- Add running the type tests directly to the `lint:ts` job.

Author: chriskrycho

addon-test-support/@ember/test-helpers/setup-application-context.ts

@@ -11,7 +11,7 @@ import hasEmberVersion from './has-ember-version';
 import settled from './settled';
 import getTestMetadata from './test-metadata';
 import { runHooks } from './-internal/helper-hooks';
-import type { Router } from '@ember/routing';
+import type Router from '@ember/routing/router';
 import type RouterService from '@ember/routing/router-service';
 import { assert } from '@ember/debug';
 

addon-test-support/@ember/test-helpers/setup-rendering-context.ts

@@ -54,7 +54,7 @@ export function isRenderingTestContext(
   @param {string} templateFullName the fill template name
   @returns {Template} the template representing `templateFullName`
 */
-function lookupTemplate(owner: Owner, templateFullName: string) {
+function lookupTemplate(owner: Owner, templateFullName: `${string}:${string}`) {
   let template = owner.lookup(templateFullName);
   if (typeof template === 'function') return template(owner);
   return template;
@@ -139,7 +139,7 @@ export function render(
         }
 
         templateId += 1;
-        let templateFullName = `template:-undertest-${templateId}`;
+        let templateFullName = `template:-undertest-${templateId}` as const;
         ownerToRenderFrom.register(templateFullName, templateOrComponent);
         templateOrComponent = lookupTemplate(
           ownerToRenderFrom,
@@ -172,7 +172,7 @@ export function render(
           templateOrComponent = INVOKE_PROVIDED_COMPONENT;
         } else {
           templateId += 1;
-          let templateFullName = `template:-undertest-${templateId}`;
+          let templateFullName = `template:-undertest-${templateId}` as const;
           ownerToRenderFrom.register(templateFullName, templateOrComponent);
           templateOrComponent = lookupTemplate(
             ownerToRenderFrom,

package.json

@@ -32,7 +32,7 @@
     "docs": "documentation build --document-exported \"addon-test-support/@ember/test-helpers/index.js\" --config documentation.yml --markdown-toc-max-depth 3 -f md -o API.md",
     "lint": "npm-run-all lint:*",
     "lint:js": "eslint --cache .",
-    "lint:ts": "tsc -p tsconfig.json --noEmit",
+    "lint:ts": "tsc --noEmit && tsc --noEmit --project type-tests",
     "postpublish": "npm-run-all clean",
     "release": "release-it",
     "start": "ember serve",
@@ -44,12 +44,12 @@
   },
   "dependencies": {
     "@ember/test-waiters": "^3.0.0",
-    "@embroider/macros": "^1.6.0",
-    "@embroider/util": "^1.6.0",
+    "@embroider/macros": "^1.10.0",
+    "@embroider/util": "^1.9.0",
     "broccoli-debug": "^0.6.5",
     "broccoli-funnel": "^3.0.8",
-    "ember-cli-babel": "^7.26.6",
-    "ember-cli-htmlbars": "^5.7.1",
+    "ember-cli-babel": "^7.26.11",
+    "ember-cli-htmlbars": "^6.1.1",
     "ember-destroyable-polyfill": "^2.0.3"
   },
   "devDependencies": {
@@ -61,18 +61,19 @@
     "@glimmer/reference": "^0.84.1",
     "@tsconfig/ember": "^1.0.1",
     "@types/ember": "~4.0.0",
+    "@types/ember-resolver": "^5.0.13",
+    "@types/ember-testing-helpers": "^0.0.4",
     "@types/ember__application": "~4.0.0",
     "@types/ember__component": "~4.0.8",
     "@types/ember__debug": "~4.0.1",
     "@types/ember__destroyable": "~4.0.0",
     "@types/ember__engine": "~4.0.0",
     "@types/ember__object": "~4.0.2",
-    "@types/ember__routing": "~4.0.7",
     "@types/ember__polyfills": "~4.0.0",
+    "@types/ember__routing": "~4.0.7",
     "@types/ember__runloop": "~4.0.1",
     "@types/ember__service": "~4.0.0",
     "@types/ember__test": "~4.0.0",
-    "@types/ember-testing-helpers": "^0.0.4",
     "@types/rsvp": "^4.0.4",
     "@typescript-eslint/eslint-plugin": "^4.29.0",
     "@typescript-eslint/parser": "^4.29.0",

tests/api.ts type-tests/api.tstests/api.ts renamed to type-tests/api.ts

@@ -0,0 +1,17 @@
+{
+  "extends": "@tsconfig/ember",
+  "compilerOptions": {
+    "baseUrl": "..",
+    "paths": {
+      "@ember/test-helpers": [
+        "./addon-test-support/@ember/test-helpers"
+      ],
+      "@ember/test-helpers/*": [
+        "./addon-test-support/@ember/test-helpers/*"
+      ],
+      "*": [
+        "types/*"
+      ]
+    }
+  }
+}