Manual lint-fixes, more disables

Author: NullVoxPopuli

addon/.eslintrc.cjs

@@ -41,9 +41,20 @@ module.exports = {
         // (public types do not always exist for the things we need to import)
         '@typescript-eslint/ban-ts-comment': 'off',
         '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/ban-types': 'off',
         // We access the _routerMicrolib
         // and router:main
         'ember/no-private-routing-service': 'off',
+        // This library must violate this rule so that consumers
+        // can have some additional protections for working _with_ this rule.
+        'ember/no-ember-testing-in-module-scope': 'off',
+        // Used in `setupRenderingContext` to hook in to "appendTo"
+        // on the -top-level-view:main
+        'ember/no-runloop': 'off',
+        // For accessing container_proxy and registry_proxy
+        'ember/no-mixins': 'off',
+        // We violate this for making the owner in build-registry.
+        'ember/no-classic-classes': 'off',
       },
     },
     {

addon/src/dom/trigger-key-event.ts

@@ -215,12 +215,6 @@ export function __triggerKeyEvent__(
   });
 }
 
-// eslint-disable-next-line require-jsdoc
-function errorMessage(message: string, target: Target) {
-  const description = getDescription(target);
-  return `${message} when calling \`triggerKeyEvent('${description}')\`.`;
-}
-
 /**
   Triggers a keyboard event of given type in the target element.
   It also requires the developer to provide either a string with the [`key`](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values)

addon/src/dom/wait-for.ts

@@ -41,7 +41,9 @@ export default function waitFor(
       );
     }
 
-    let { timeout = 1000, count = null, timeoutMessage } = options;
+    const { timeout = 1000, count = null } = options;
+    let { timeoutMessage } = options;
+
     if (!timeoutMessage) {
       const description = getDescription(target);
       timeoutMessage = `waitFor timed out waiting for selector "${description}"`;

addon/src/has-ember-version.ts

@@ -1,4 +1,5 @@
-import Ember from 'ember';
+// @ts-ignore
+import { VERSION } from '@ember/version';
 
 /**
   Checks if the currently running Ember version is greater than or equal to the
@@ -10,7 +11,7 @@ import Ember from 'ember';
   @returns {boolean} true if the Ember version is >= MAJOR.MINOR specified, false otherwise
 */
 export default function hasEmberVersion(major: number, minor: number): boolean {
-  const numbers = Ember.VERSION.split('-')[0]?.split('.');
+  const numbers = VERSION.split('-')[0]?.split('.');
 
   if (!numbers || !numbers[0] || !numbers[1]) {
     throw new Error('`Ember.VERSION` is not set.');

addon/src/settled.ts

@@ -1,4 +1,3 @@
-/* globals jQuery */
 // @ts-ignore: this is private API. This import will work Ember 5.1+ since it
 // "provides" this public API, but does not for earlier versions. As a result,
 // this type will be `any`.

addon/src/setup-context.ts

@@ -215,6 +215,7 @@ export function resumeTest(): void {
   @private
   @param {Object} context the test context being cleaned up
 */
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 function cleanup(context: BaseContext) {
   _teardownAJAXHooks();
 

addon/src/setup-rendering-context.ts

@@ -1,4 +1,3 @@
-/* globals EmberENV */
 import { run } from '@ember/runloop';
 import Ember from 'ember';
 import global from './global.ts';
@@ -40,7 +39,6 @@ export interface RenderingTestContext extends TestContext {
 //  Isolates the notion of transforming a TextContext into a RenderingTestContext.
 // eslint-disable-next-line require-jsdoc
 function prepare(context: TestContext): RenderingTestContext {
-  const renderingTestContext = context as RenderingTestContext;
   (context as RenderingTestContext)[hasCalledSetupRenderingContext] = true;
   return context as RenderingTestContext;
 }