Merge pull request #352 from emberjs/bugfix-npm-security-audit

update inquirer and glob (to clear audit warnings) and drop support for node < 20.19

Author: mansona

.github/workflows/ci.yml

@@ -14,16 +14,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
         cache: npm
-    - run: npm i -g npm@7
-      if: ${{ matrix.node-version == '10.x' || matrix.node-version == '12.x' || matrix.node-version == '14.x' }}
     - run: npm ci
     - run: npm run lint:js
     - run: npm test

features/application-template-wrapper.js

@@ -72,8 +72,8 @@ module.exports = {
 
         To be very conservative, I could add the \`<div class="ember-view">\` wrapper to your application.hbs. (You can always remove it later.)
       `);
-
-      let response = await require('inquirer').prompt({
+      const prompt = require('inquirer').createPromptModule();
+      let response = await prompt({
         type: 'confirm',
         name: 'shouldRewrite',
         message: 'Would you like me to do that for you?',

features/template-only-glimmer-components.js

@@ -3,7 +3,7 @@
 
 const chalk = require('chalk');
 const fs = require('fs');
-const glob = require('glob');
+const globSync = require('glob').globSync;
 const mkdirp = require('mkdirp');
 const p = require('util').promisify;
 const path = require('path');
@@ -65,7 +65,7 @@ module.exports = {
 
     // Handle "Classic" layout
     let templatesRoot = path.join(root, 'app/templates/components');
-    let templateCandidates = await p(glob)('**/*.hbs', { cwd: templatesRoot });
+    let templateCandidates = globSync('**/*.hbs', { cwd: templatesRoot });
 
     templateCandidates.forEach((template) => {
       let templatePath = path.join('app/templates/components', template);
@@ -89,7 +89,7 @@ module.exports = {
     // Handle "Pods" layout without prefix
 
     let componentsRoot = path.join(root, 'app/components');
-    templateCandidates = await p(glob)('**/template.hbs', {
+    templateCandidates = globSync('**/template.hbs', {
       cwd: componentsRoot,
     });
 
@@ -115,7 +115,7 @@ module.exports = {
     // Handle "Pods" layout *with* prefix
 
     componentsRoot = path.join(root, `app/${podsFolder}/components`);
-    templateCandidates = await p(glob)('**/template.hbs', {
+    templateCandidates = globSync('**/template.hbs', {
       cwd: componentsRoot,
     });
 
@@ -179,8 +179,8 @@ module.exports = {
             )}
         `);
       }
-
-      let response = await require('inquirer').prompt({
+      const prompt = require('inquirer').createPromptModule();
+      let response = await prompt({
         type: 'confirm',
         name: 'shouldGenerate',
         message: 'Would you like me to generate these component files for you?',