More coverage from template-lint

Author: NullVoxPopuli

docs/rules/template-no-outlet-outside-routes.md

@@ -34,3 +34,4 @@ Examples of **correct** code for this rule:
 
 - [Ember guides/routing](https://guides.emberjs.com/release/routing/rendering-a-template/)
 - [Ember api/outlet helper](https://api.emberjs.com/ember/release/classes/Ember.Templates.helpers/methods/outlet?anchor=outlet)
+- [ember-template-lint no-outlet-outside-routes](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-outlet-outside-routes.md)

lib/rules/template-no-outlet-outside-routes.js

@@ -5,42 +5,27 @@ const path = require('path');
  * Mirrors ember-template-lint's is-route-template.js heuristic:
  *  - If the path is unknown, assume it could be a route (don't report).
  *  - Partials (basename starts with '-') are not routes.
- *  - Classic component templates (templates/components/) are not routes.
- *  - Co-located component templates (app/components/) are not routes.
+ *  - Classic component templates (<app>/templates/components/) are not routes.
+ *  - Co-located component templates (<app>/components/) are not routes.
+ *
+ * Note: GJS/GTS files can be route templates (e.g. app/routes/foo.gjs).
  */
 function isRouteTemplate(filePath) {
   if (typeof filePath !== 'string') {
     return true; // unknown — assume it could be a route
   }
 
-  // GJS/GTS files are always components, never route templates
-  if (filePath.endsWith('.gjs') || filePath.endsWith('.gts')) {
-    return false;
-  }
-
-  const baseName = path.basename(filePath);
-
-  // Partials start with '-'
-  if (baseName.startsWith('-')) {
-    return false;
-  }
-
   const normalized = filePath.replaceAll('\\', '/');
+  const baseName = path.basename(normalized);
 
-  // Classic component template: <app>/templates/components/...
-  if (
-    /\/templates\/components\//.test(normalized) ||
-    /^[^/]+\/templates\/components\//.test(normalized)
-  ) {
-    return false;
-  }
-
-  // Co-located component: <app>/components/...
-  if (/\/components\//.test(normalized) && !/\/templates\//.test(normalized)) {
+  if (baseName.startsWith('-')) {
     return false;
   }
 
-  return true;
+  return (
+    !/^[^/]+\/templates\/components\//.test(normalized) && // classic component
+    !/^[^/]+\/components\//.test(normalized) // co-located component template
+  );
 }
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -68,9 +53,7 @@ module.exports = {
   create(context) {
     const filename = context.filename || context.getFilename();
 
-    // In GJS/GTS (strict) mode, templates are always in components — never route templates.
-    // Only .hbs files can be route templates, so apply the filePath heuristic only for those.
-    const routeTemplate = filename.endsWith('.hbs') ? isRouteTemplate(filename) : false;
+    const routeTemplate = isRouteTemplate(filename);
 
     return {
       GlimmerMustacheStatement(node) {

tests/lib/rules/template-no-outlet-outside-routes.js

@@ -16,23 +16,33 @@ ruleTester.run('template-no-outlet-outside-routes', rule, {
     '<template><div>Content</div></template>',
     '<template>{{foo}}</template>',
     '<template>{{button}}</template>',
+    // GJS route templates — outlet is allowed
+    {
+      filename: 'app/routes/foo.gjs',
+      code: '<template>{{outlet}}</template>',
+    },
+    {
+      filename: 'app/routes/foo.gts',
+      code: '<template>{{outlet}}</template>',
+    },
   ],
   invalid: [
-    // GJS files are always components — outlet should be flagged
+    // Co-located component (explicit filename)
     {
+      filename: 'app/components/my-component.gjs',
       code: '<template>{{outlet}}</template>',
       output: null,
       errors: [{ messageId: 'noOutletOutsideRoutes' }],
     },
     {
-      code: '<template><div>{{outlet}}</div></template>',
+      filename: 'app/components/my-component.gts',
+      code: '<template>{{outlet}}</template>',
       output: null,
       errors: [{ messageId: 'noOutletOutsideRoutes' }],
     },
-    // Co-located component (explicit filename)
     {
       filename: 'app/components/my-component.gjs',
-      code: '<template>{{outlet}}</template>',
+      code: '<template><div>{{outlet}}</div></template>',
       output: null,
       errors: [{ messageId: 'noOutletOutsideRoutes' }],
     },
@@ -52,9 +62,6 @@ hbsRuleTester.run('template-no-outlet-outside-routes', rule, {
     // Non-outlet usage
     '{{foo}}',
     '{{button}}',
-    // Block form is ambiguous (could be a component named "outlet")
-    '{{#outlet}}Why?!{{/outlet}}',
-    '{{#outlet}}Works because ambiguous{{/outlet}}',
     // Route templates — outlet is allowed
     {
       filename: 'app/templates/foo/route.hbs',
@@ -64,12 +71,21 @@ hbsRuleTester.run('template-no-outlet-outside-routes', rule, {
       filename: 'app/templates/routes/foo.hbs',
       code: '{{outlet}}',
     },
+    // Block form in route templates
+    {
+      filename: 'app/templates/foo/route.hbs',
+      code: '{{#outlet}}Why?!{{/outlet}}',
+    },
+    {
+      filename: 'app/templates/routes/foo.hbs',
+      code: '{{#outlet}}Why?!{{/outlet}}',
+    },
     // Ambiguous path — not clearly a component, so allowed
     {
       filename: 'app/templates/something/foo.hbs',
-      code: '{{outlet}}',
+      code: '{{#outlet}}Works because ambiguous{{/outlet}}',
     },
-    // "components" in the prefix but not under templates/components/ or app/components/
+    // "components" appears in prefix but not under <app>/templates/components/ or <app>/components/
     {
       filename: 'components/templates/application.hbs',
       code: '{{outlet}}',