Fix template-no-log: add isLocal check for block params

Prevent false positives when log is a locally-scoped block parameter.
The original ember-template-lint rule checks isLocal before reporting;
this was missing from the extraction. Also adds block-param scoping tests.

Author: johanrd

lib/rules/template-no-log.js

@@ -15,8 +15,32 @@ module.exports = {
   },
 
   create(context) {
+    const localScopes = [];
+
+    function pushLocals(params) {
+      localScopes.push(new Set(params || []));
+    }
+
+    function popLocals() {
+      localScopes.pop();
+    }
+
+    function isLocal(name) {
+      for (const scope of localScopes) {
+        if (scope.has(name)) {
+          return true;
+        }
+      }
+      return false;
+    }
+
     function checkForLog(node) {
-      if (node.path && node.path.type === 'GlimmerPathExpression' && node.path.original === 'log') {
+      if (
+        node.path &&
+        node.path.type === 'GlimmerPathExpression' &&
+        node.path.original === 'log' &&
+        !isLocal('log')
+      ) {
         context.report({
           node,
           messageId: 'unexpected',
@@ -25,11 +49,30 @@ module.exports = {
     }
 
     return {
-      GlimmerMustacheStatement(node) {
+      GlimmerBlockStatement(node) {
+        if (node.program && node.program.blockParams) {
+          pushLocals(node.program.blockParams);
+        }
         checkForLog(node);
       },
+      'GlimmerBlockStatement:exit'(node) {
+        if (node.program && node.program.blockParams) {
+          popLocals();
+        }
+      },
 
-      GlimmerBlockStatement(node) {
+      GlimmerElementNode(node) {
+        if (node.blockParams && node.blockParams.length > 0) {
+          pushLocals(node.blockParams);
+        }
+      },
+      'GlimmerElementNode:exit'(node) {
+        if (node.blockParams && node.blockParams.length > 0) {
+          popLocals();
+        }
+      },
+
+      GlimmerMustacheStatement(node) {
         checkForLog(node);
       },
     };

tests/lib/rules/template-no-log.js

@@ -28,6 +28,22 @@ ruleTester.run('template-no-log', rule, {
     `<template>
       <div data-test-log={{true}}></div>
     </template>`,
+    // Block param: log as a yielded value should not be flagged
+    `<template>
+      {{#each this.logs as |log|}}{{log}}{{/each}}
+    </template>`,
+    `<template>
+      {{#let this.log as |log|}}{{log}}{{/let}}
+    </template>`,
+    `<template>
+      {{#let (component "my-log-component") as |log|}}{{#log}}message{{/log}}{{/let}}
+    </template>`,
+    `<template>
+      <Logs @logs={{this.logs}} as |log|>{{log}}</Logs>
+    </template>`,
+    `<template>
+      <Logs @logs={{this.logs}} as |log|><Log>{{log}}</Log></Logs>
+    </template>`,
   ],
 
   invalid: [
@@ -71,5 +87,42 @@ ruleTester.run('template-no-log', rule, {
         },
       ],
     },
+    // log helper used inside a block that does NOT shadow it
+    {
+      code: `<template>
+        {{#each this.messages as |message|}}{{log message}}{{/each}}
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Unexpected log statement in template.',
+          type: 'GlimmerMustacheStatement',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        {{#let this.message as |message|}}{{log message}}{{/let}}
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Unexpected log statement in template.',
+          type: 'GlimmerMustacheStatement',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        <Messages @messages={{this.messages}} as |message|>{{#log}}{{message}}{{/log}}</Messages>
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Unexpected log statement in template.',
+          type: 'GlimmerBlockStatement',
+        },
+      ],
+    },
   ],
 });