Skip to content

no-test-import-export.md

Latest commit

 

History

History
76 lines (52 loc) · 1.6 KB

no-test-import-export.md

File metadata and controls

76 lines (52 loc) · 1.6 KB

No importing of test files

TL;DR Do not import from a test file (a file ending in "-test.js") in another test file. Doing so will cause the module and tests from the imported file to be executed again. Similarly, test files should not have any exports.

Due to how qunit unloads a test module, importing a test file will cause any modules and tests within the file to be executed every time it gets loaded. If you want to import any helper functions or tests to be shared between multiple test files, please make it a test-helper that gets imported by the test file.

// GOOD

import setupModule from './some-test-helper';
import { module, test } from 'qunit';

module('Acceptance | module', setupModule());
// GOOD

// some-test-helper.js
export function beforeEachSetup(){ ... };
// GOOD

// some-test-helper.js
function beforeEachSetup(){};

export default {beforeEachSetup};
// BAD

import setupModule from './some-other-test';
import { module, test } from 'qunit';

module('Acceptance | module', setupModule());
// BAD

import {
  beforeEachSetup,
  testMethod,
} from './some-other-test';
import { module, test } from 'qunit';

module('Acceptance | module', beforeEachSetup());
// BAD

import testModule from '../../test-dir/another-test';
import { module, test } from 'qunit';

module('Acceptance | module', testModule());
// BAD

// some-test.js
export function beforeEachSetup(){};
// BAD

// some-test.js
function beforeEachSetup(){};

export default {beforeEachSetup};