-
-
Notifications
You must be signed in to change notification settings - Fork 211
Expand file tree
/
Copy pathavoid-leaking-callbacks-in-ember-objects.js
More file actions
67 lines (56 loc) · 1.97 KB
/
avoid-leaking-callbacks-in-ember-objects.js
File metadata and controls
67 lines (56 loc) · 1.97 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
'use strict';
// const ember = require('../utils/ember');
const utils = require('../utils/utils');
const ERROR_MESSAGE = 'All `addEventListener` calls should have a corresponding `removeEventListener` to avoid leaking callbacks.';
//------------------------------------------------------------------------------
// Ember object rule - Avoid callback memory leaks
// Callback leaks are memory leaks that occur due to state being caught
// in a callback function that is never released from memory.
//------------------------------------------------------------------------------
module.exports = {
meta: {
docs: {
description: 'Avoids callback memory leaks',
category: 'Ember Object',
recommended: true,
url: 'https://github.com/ember-best-practices/memory-leak-examples/blob/master/exercises/exercise-2.md'
},
fixable: null, // or "code" or "whitespace"
ERROR_MESSAGE,
},
create(context) {
const report = function (node) {
context.report(node, ERROR_MESSAGE);
};
const addedListeners = [];
const removedListeners = [];
return {
'Program:exit': function () {
addedListeners.forEach((a) => {
const idx = removedListeners.findIndex(r => r.el === a.el && r.event === a.event);
if (idx < 0) {
// No removeEventListener
report(a.node);
}
});
},
CallExpression(node) {
if (utils.getPropertyValue(node, 'callee.property.name') === 'addEventListener') {
const listener = {
el: node.callee.object.name,
event: node.arguments[0].value,
node
};
addedListeners.push(listener);
}
if (utils.getPropertyValue(node, 'callee.property.name') === 'removeEventListener') {
const listener = {
el: node.callee.object.name,
event: node.arguments[0].value
};
removedListeners.push(listener);
}
}
};
},
};