Commit dba6019
committed
Use Elixir's default slice implementation
`Enumerable.List.slice` changed in Elixir 1.10, so this fixes:
```
warning: Enumerable.List.slice/3 is undefined or private. Did you mean one of:
* slice/1
* slice/4
lib/circular_buffer.ex:90: Enumerable.CircularBuffer.slice/1
```
Elixir's default slice implementation calls reduce and this change works
in Elixir 1.8 - 1.10. I didn't test earlier versions.
This commit also adds a test to verify that `Enum.slice` works at least
as well as the Elixir's implementation for lists.1 parent f58627a commit dba6019
2 files changed
Lines changed: 33 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
| 89 | + | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
115 | 146 | | |
116 | 147 | | |
117 | 148 | | |
| |||
0 commit comments