Instructions on how to contibute

[rupurt]

Howdy 👋

I'm trying to contribute to the ecto 3 upgrade that @DiodonHystrix has started here. Are there any instructions on how to get the environment setup for development?

I've cloned the repo and when I run mix test it asks me to create the database. However there are no repositories defined in config/config.exs. Do I need to define one?

I also had a look at how the tests are running in CI and it looks like it uses mix coveralls.circle to run the tests, but again I don't see where the database is created?

Any help would be appreciated 🍻

[adamzapasnik]

Hey @rupurt
Thanks for help 👍 I haven't had time to continue working on it :/
Unfortunately, I don't remember how I set it up and now I don't have an access to an environment I was working with.
I will try to look into it if no one else answers.

[adamzapasnik]

OK, I had some time to look into it.
Problem was related to missing sqlitex dependency. Long story short, I forgot to upload changes to github and switch path to git in mix.exs

I think I have fixed it, but you have to fetch a new changes from my repository. Then run mix test and experience a couple of tests failing 🎉

[rupurt]

Thanks @DiodonHystrix. I can confirm the tests are now running.

I don't know how the internals of Ecto work but I will try learn it and chip away at the upgrade. I have a need for Ecto 3 + SQLite in my app.

[dimitarvp]

@rupurt Me too, and I'd like to start an effort to make an Ecto 3.1.x Sqlite adapter. Where are you on that effort at the moment?

[rupurt]

@dimitarvp nowhere 😄

I've been moving house so won't be able to start investigating until at least next weekend. I'm assuming it's going to take months tbh.

[dimitarvp]

@rupurt Thanks for being honest! 👍

I started a library locally from scratch. I'll try gradually copy-pasting code from sqlite_ecto2 to it and see where it goes. Will announce on ElixirForum when something is ready.

As yourself, I have quite a lot of logistics to handle in my life so might be a while. But I've started.

[rupurt]

Thanks for the info. Starting is half the battle 😛 Good luck!

[dimitarvp]

After banging my head for several hours, I came to the conclusion that I am not just going to make an Ecto3 adapter for Sqlitex, no.

I think I am just going to roll my own Sqlitex (with another name of course) and build an adapter on top of that.

Lots of adventures and cursing ahead.

[mfrasca]

hi @dimitarvp , don't forget to commit early and often. you're working here, aren't you!

[dimitarvp]

@mfrasca Yeah I started a separate skeleton project which I'll maintain for a bit. I'd like to see if I can do better from scratch or I'll just start pouring PRs both to Sqlitex and Sqlite.Ecto2. That is yet to be determined -- and also depends on how responsive and receptive would their maintainers be.

Reasoning:

• I found a lot of configuration options for Sqlite3 which I want to expose to an underlying raw Sqlite3 library, not the Ecto adapter itself.
• I want to avoid Mix.Config since it's now deprecated (in Elixir 1.9). I'm gonna experiment in my repo with a process dictionary configuration, or GenServer state. Not yet determined.
• I am not interested in supporting very old Elixir versions, not to mention that one of the Sqlitex dependencies mandates Elixir 1.7 anyway.

[mfrasca]

three points worth mentioning in the readme of your project, I suggest.
but where's the current status of your code? with a nice whole bunch of failing tests?
even though, well, maybe I'll open an issue there, that's the proper place to ask the question!

[dimitarvp]

Hey, I just started, and I have a lot of work and personal tasks to accomplish in the meantime, all the time. The project is online in GitHub only out of paranoia -- don't want to lose any coding progress if my laptop's SSD dies.

Don't expect anything workable for at least a month. Sadly, all of us who want to work on open-source software for real, have to juggle a lot of responsibilities.

[mfrasca]

yep, that's true. I'm pointing out because I see lots of loose threads on the same subject, and your boilerplate project is the only concrete published attempt I could see.
I don't expect anything working any soon, I have hardly any experience with this environment, I come from two decades Python, several years with SQLAlchemy and some time with Django. I would be happy to see a shared attempt, that's all. where we publish early. very early.