feat: continued v4.1 impl

Signed-off-by: Sam Gammon <sam@elide.ventures>

Author: sgammon

.github/codecov.yml

@@ -1,14 +1,31 @@
 codecov:
-  require_ci_to_pass: yes
+  max_report_age: off
+  require_ci_to_pass: true
+  notify:
+    wait_for_ci: true
 
-ignore:
-  - "__tests__"
-  - "dist"
-  - "node_modules"
+coverage:
+  precision: 2
+  round: down
+  range: "80...100"
+  status:
+    project:
+      default:
+        informational: true
+    patch: off
 
-comment:                  # this is a top-level key
-  layout: "diff, flags, files"
+comment:
+  layout: "reach,diff,flags,files,footer"
   behavior: default
   require_changes: false
-  require_base: false
-  require_head: true
+
+parsers:
+  javascript:
+    enable_partials: yes
+
+github_checks:
+  annotations: true
+
+bundle_analysis:
+  require_bundle_changes: "bundle_increase"
+  bundle_change_threshold: "1Kb"

.github/workflows/ci.yml

@@ -48,12 +48,37 @@ jobs:
 
       - name: Test
         id: test
-        run: bun run test
+        run: bun run test:ci
 
-      - name: "Report: Coverage"
+      - name: "Upload: Test Results"
+        if: ${{ !cancelled() && hashFiles('test-results/**') != '' }}
         uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          report_type: test_results
+          files: test-results/batch1.xml,test-results/batch2.xml,test-results/batch3.xml,test-results/batch4.xml,test-results/batch5.xml,test-results/batch6.xml
+          fail_ci_if_error: false
+
+      - name: "Upload: Coverage"
+        if: ${{ !cancelled() && hashFiles('coverage/**') != '' }}
+        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          directory: ./coverage
+          files: coverage/lcov.info
+          fail_ci_if_error: false
+
+      - name: Build
+        run: bun run build
+
+      - name: "Upload: Bundle Analysis"
+        if: ${{ !cancelled() }}
+        run: |
+          bun x @codecov/bundle-analyzer ./dist \
+            --bundle-name=setup-elide \
+            --upload-token=${{ secrets.CODECOV_TOKEN }} \
+            --config-file=codecov-bundle.json
+        continue-on-error: true
 
   test-action:
     name: "Test: ${{ matrix.name }}"

__tests__/main.test.ts

@@ -69,10 +69,19 @@ mock.module('../src/command', () => ({
   ElideCommand: { RUN: 'run', INFO: 'info' },
   ElideArgument: { VERSION: '--version' }
 }))
+const withSpanMock = jest.fn(
+  async (_name: string, _op: string, fn: () => Promise<any>) => fn()
+)
+const recordMetricMock = jest.fn()
+const logEventMock = jest.fn()
+
 mock.module('../src/telemetry', () => ({
   initTelemetry: initTelemetryMock,
   reportError: reportErrorMock,
-  flushTelemetry: flushTelemetryMock
+  flushTelemetry: flushTelemetryMock,
+  withSpan: withSpanMock,
+  recordMetric: recordMetricMock,
+  logEvent: logEventMock
 }))
 
 const main = await import('../src/main')
@@ -117,6 +126,9 @@ describe('action', () => {
     initTelemetryMock.mockClear()
     reportErrorMock.mockClear()
     flushTelemetryMock.mockClear()
+    withSpanMock.mockClear()
+    recordMetricMock.mockClear()
+    logEventMock.mockClear()
     summaryMock.addHeading.mockClear()
     summaryMock.addTable.mockClear()
     summaryMock.write.mockClear()
@@ -138,6 +150,9 @@ describe('action', () => {
     elideInfoMock.mockResolvedValue(undefined)
     obtainVersionMock.mockResolvedValue('1.0.0')
     flushTelemetryMock.mockResolvedValue(undefined)
+    withSpanMock.mockImplementation(
+      async (_name: string, _op: string, fn: () => Promise<any>) => fn()
+    )
   })
 
   it('reads option inputs', async () => {
@@ -198,6 +213,50 @@ describe('action', () => {
     expect(setFailedMock).toHaveBeenCalled()
   })
 
+  it('should emit start and exit log events', async () => {
+    setupMocks()
+    await main.run({ force: true, installer: 'shell' })
+    expect(logEventMock).toHaveBeenCalledWith(
+      'setup-elide.start',
+      expect.objectContaining({ installer: 'shell' })
+    )
+    expect(logEventMock).toHaveBeenCalledWith(
+      'setup-elide.exit',
+      expect.objectContaining({ status: 'success' })
+    )
+  })
+
+  it('should record install duration metric', async () => {
+    setupMocks()
+    await main.run({ force: true, installer: 'shell' })
+    expect(recordMetricMock).toHaveBeenCalledWith(
+      'setup_elide.duration_ms',
+      expect.any(Number),
+      'millisecond',
+      expect.objectContaining({ installer: 'shell' })
+    )
+  })
+
+  it('should wrap install in tracing spans', async () => {
+    setupMocks()
+    await main.run({ force: true, installer: 'shell' })
+    expect(withSpanMock).toHaveBeenCalledWith(
+      'setup-elide',
+      'setup',
+      expect.any(Function)
+    )
+    expect(withSpanMock).toHaveBeenCalledWith(
+      'install.shell',
+      'install',
+      expect.any(Function)
+    )
+    expect(withSpanMock).toHaveBeenCalledWith(
+      'verify',
+      'verify',
+      expect.any(Function)
+    )
+  })
+
   it('should use grouped output', async () => {
     setupMocks()
     await main.run({ force: true, installer: 'shell' })

__tests__/telemetry.test.ts

@@ -3,30 +3,44 @@ import { describe, it, expect, beforeEach, jest, mock } from 'bun:test'
 const initMock = jest.fn()
 const setTagsMock = jest.fn()
 const captureExceptionMock = jest.fn()
+const captureMessageMock = jest.fn()
 const withScopeMock = jest.fn((cb: (scope: any) => void) => {
   cb({ setTag: jest.fn() })
 })
+const startSpanMock = jest.fn((_opts: any, fn: () => Promise<any>) => fn())
+const metricsGaugeMock = jest.fn()
 const flushMock = jest.fn().mockResolvedValue(true)
 
 mock.module('@sentry/node', () => ({
   init: initMock,
   setTags: setTagsMock,
   captureException: captureExceptionMock,
+  captureMessage: captureMessageMock,
   withScope: withScopeMock,
+  startSpan: startSpanMock,
+  metrics: { gauge: metricsGaugeMock },
   flush: flushMock
 }))
 
-const { initTelemetry, reportError, flushTelemetry } = await import(
-  '../src/telemetry'
-)
+const {
+  initTelemetry,
+  reportError,
+  flushTelemetry,
+  withSpan,
+  recordMetric,
+  logEvent
+} = await import('../src/telemetry')
 const { default: buildOptions } = await import('../src/options')
 
 describe('telemetry', () => {
   beforeEach(() => {
     initMock.mockClear()
     setTagsMock.mockClear()
     captureExceptionMock.mockClear()
+    captureMessageMock.mockClear()
     withScopeMock.mockClear()
+    startSpanMock.mockClear()
+    metricsGaugeMock.mockClear()
     flushMock.mockClear()
   })
 
@@ -42,7 +56,8 @@ describe('telemetry', () => {
     expect(initMock).toHaveBeenCalledWith(
       expect.objectContaining({
         defaultIntegrations: false,
-        environment: 'nightly'
+        environment: 'nightly',
+        tracesSampleRate: 1.0
       })
     )
   })
@@ -90,8 +105,25 @@ describe('telemetry', () => {
     expect(scrubbed.contexts).toEqual({})
   })
 
+  it('should strip sensitive data in beforeSendTransaction', () => {
+    const options = buildOptions({})
+    initTelemetry(true, options)
+
+    const beforeSendTransaction =
+      initMock.mock.calls[0][0].beforeSendTransaction
+    const event = {
+      server_name: 'runner-abc',
+      extra: { leak: true },
+      contexts: { something: {} }
+    }
+
+    const scrubbed = beforeSendTransaction(event)
+    expect(scrubbed.server_name).toBeUndefined()
+    expect(scrubbed.extra).toBeUndefined()
+    expect(scrubbed.contexts).toEqual({})
+  })
+
   it('should scrub exception values of env var secrets', () => {
-    // Set a fake sensitive env var
     const originalToken = process.env.GITHUB_TOKEN
     process.env.GITHUB_TOKEN = 'ghp_superSecretTokenValue123'
     try {
@@ -127,10 +159,7 @@ describe('telemetry', () => {
   it('should report errors via captureException', () => {
     const options = buildOptions({})
     initTelemetry(true, options)
-
-    const err = new Error('install failed')
-    reportError(err)
-
+    reportError(new Error('install failed'))
     expect(withScopeMock).toHaveBeenCalled()
   })
 
@@ -144,8 +173,6 @@ describe('telemetry', () => {
     })
 
     reportError(new Error('fail'), { phase: 'download' })
-
-    expect(withScopeMock).toHaveBeenCalled()
     expect(setTagMock).toHaveBeenCalledWith('phase', 'download')
   })
 
@@ -155,6 +182,61 @@ describe('telemetry', () => {
     expect(withScopeMock).not.toHaveBeenCalled()
   })
 
+  // --- Tracing ---
+
+  it('withSpan should call Sentry.startSpan when enabled', async () => {
+    initTelemetry(true, buildOptions({}))
+    const result = await withSpan('test-op', 'test', async () => 42)
+    expect(result).toBe(42)
+    expect(startSpanMock).toHaveBeenCalledWith(
+      expect.objectContaining({ name: 'test-op', op: 'test' }),
+      expect.any(Function)
+    )
+  })
+
+  it('withSpan should run function directly when disabled', async () => {
+    initTelemetry(false, buildOptions({}))
+    const result = await withSpan('test-op', 'test', async () => 99)
+    expect(result).toBe(99)
+    expect(startSpanMock).not.toHaveBeenCalled()
+  })
+
+  // --- Metrics ---
+
+  it('recordMetric should call metrics.gauge when enabled', () => {
+    initTelemetry(true, buildOptions({}))
+    recordMetric('install_duration', 1500, 'millisecond', { os: 'linux' })
+    expect(metricsGaugeMock).toHaveBeenCalledWith('install_duration', 1500, {
+      unit: 'millisecond',
+      tags: { os: 'linux' }
+    })
+  })
+
+  it('recordMetric should no-op when disabled', () => {
+    initTelemetry(false, buildOptions({}))
+    recordMetric('install_duration', 1500, 'millisecond')
+    expect(metricsGaugeMock).not.toHaveBeenCalled()
+  })
+
+  // --- Logging ---
+
+  it('logEvent should call captureMessage when enabled', () => {
+    initTelemetry(true, buildOptions({}))
+    logEvent('setup-elide.start', { installer: 'shell' })
+    expect(captureMessageMock).toHaveBeenCalledWith('setup-elide.start', {
+      level: 'info',
+      tags: { installer: 'shell' }
+    })
+  })
+
+  it('logEvent should no-op when disabled', () => {
+    initTelemetry(false, buildOptions({}))
+    logEvent('setup-elide.start')
+    expect(captureMessageMock).not.toHaveBeenCalled()
+  })
+
+  // --- Flush ---
+
   it('should flush pending events', async () => {
     initTelemetry(true, buildOptions({}))
     await flushTelemetry()

codecov-bundle.json

@@ -0,0 +1,4 @@
+{
+  "ignorePatterns": ["*.map"],
+  "normalizeAssetsPattern": "[name].js"
+}

dist/index.js

@@ -60,7 +60,8 @@
     "lint": "oxlint src __tests__",
     "package": "bun build src/index.ts src/post.ts --outdir=dist --target=node --minify --sourcemap=linked",
     "package:watch": "bun build src/index.ts src/post.ts --outdir=dist --target=node --sourcemap=linked --watch",
-    "test": "bun test __tests__/options.test.ts __tests__/platform.test.ts __tests__/releases.test.ts __tests__/index.test.ts && bun test __tests__/command.test.ts && bun test __tests__/releases-download.test.ts && bun test __tests__/telemetry.test.ts && bun test __tests__/install-apt.test.ts __tests__/install-shell.test.ts __tests__/install-msi.test.ts __tests__/install-pkg.test.ts __tests__/install-rpm.test.ts && bun test __tests__/main.test.ts",
+    "test": "rm -rf coverage && bun test __tests__/options.test.ts __tests__/platform.test.ts __tests__/releases.test.ts __tests__/index.test.ts && cp coverage/lcov.info coverage/batch1.info && bun test __tests__/command.test.ts && cp coverage/lcov.info coverage/batch2.info && bun test __tests__/releases-download.test.ts && cp coverage/lcov.info coverage/batch3.info && bun test __tests__/telemetry.test.ts && cp coverage/lcov.info coverage/batch4.info && bun test __tests__/install-apt.test.ts __tests__/install-shell.test.ts __tests__/install-msi.test.ts __tests__/install-pkg.test.ts __tests__/install-rpm.test.ts && cp coverage/lcov.info coverage/batch5.info && bun test __tests__/main.test.ts && cp coverage/lcov.info coverage/batch6.info && cat coverage/batch*.info > coverage/lcov.info",
+    "test:ci": "rm -rf coverage test-results && mkdir -p test-results && bun test --reporter=junit --reporter-outfile=test-results/batch1.xml __tests__/options.test.ts __tests__/platform.test.ts __tests__/releases.test.ts __tests__/index.test.ts && cp coverage/lcov.info coverage/batch1.info && bun test --reporter=junit --reporter-outfile=test-results/batch2.xml __tests__/command.test.ts && cp coverage/lcov.info coverage/batch2.info && bun test --reporter=junit --reporter-outfile=test-results/batch3.xml __tests__/releases-download.test.ts && cp coverage/lcov.info coverage/batch3.info && bun test --reporter=junit --reporter-outfile=test-results/batch4.xml __tests__/telemetry.test.ts && cp coverage/lcov.info coverage/batch4.info && bun test --reporter=junit --reporter-outfile=test-results/batch5.xml __tests__/install-apt.test.ts __tests__/install-shell.test.ts __tests__/install-msi.test.ts __tests__/install-pkg.test.ts __tests__/install-rpm.test.ts && cp coverage/lcov.info coverage/batch5.info && bun test --reporter=junit --reporter-outfile=test-results/batch6.xml __tests__/main.test.ts && cp coverage/lcov.info coverage/batch6.info && cat coverage/batch*.info > coverage/lcov.info",
     "test:docker": "docker build -t setup-elide-test . && docker run --rm setup-elide-test sh -c 'bun run build && bun run test'",
     "all": "bun run format:write && bun run build && bun run test"
   },