URLEncode spaces in CloudFront invalidation requests.

john-shaffer · john-shaffer · commit f3ae6d76746a · 2020-08-10T18:15:17.000-05:00
diff --git a/src/Deployer.php b/src/Deployer.php
@@ -117,6 +117,7 @@ public function upload_files( string $processed_site_path ) : void {
                         if ( 0 === substr_compare( $cf_key, '/index.html', -11 ) ) {
                             $cf_key = substr( $cf_key, 0, -10 );
                         }
+                        $cf_key = str_replace( ' ', '%20', $cf_key );
                         array_push( $cf_stale_paths, $cf_key );
                     }
                 }
@@ -165,6 +166,7 @@ public function upload_files( string $processed_site_path ) : void {
                     if ( 0 === substr_compare( $cf_key, '/index.html', -11 ) ) {
                         $cf_key = substr( $cf_key, 0, -10 );
                     }
+                    $cf_key = str_replace( ' ', '%20', $cf_key );
                     array_push( $cf_stale_paths, $cf_key );
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ public function upload_files( string $processed_site_path ) : void {`
`117`	`117`	`if ( 0 === substr_compare( $cf_key, '/index.html', -11 ) ) {`
`118`	`118`	`$cf_key = substr( $cf_key, 0, -10 );`
`119`	`119`	`}`
	`120`	`+ $cf_key = str_replace( ' ', '%20', $cf_key );`
`120`	`121`	`array_push( $cf_stale_paths, $cf_key );`
`121`	`122`	`}`
`122`	`123`	`}`
`@@ -165,6 +166,7 @@ public function upload_files( string $processed_site_path ) : void {`
`165`	`166`	`if ( 0 === substr_compare( $cf_key, '/index.html', -11 ) ) {`
`166`	`167`	`$cf_key = substr( $cf_key, 0, -10 );`
`167`	`168`	`}`
	`169`	`+ $cf_key = str_replace( ' ', '%20', $cf_key );`
`168`	`170`	`array_push( $cf_stale_paths, $cf_key );`
`169`	`171`	`}`
`170`	`172`	`}`