Skip to content

Commit 9250eaf

Browse files
authored
Tweak buf breaking rules to be clearer about preferred mitigation when fields/enums are deleted. (#22)
* Tweak `buf breaking` rules to be clearer about what we want done when fields/enums are deleted. Also remove deprecated `ZONE_STATE_EXITED` * Also exclude these
1 parent 304a988 commit 9250eaf

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

buf.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,17 @@ lint:
1616
use:
1717
- STANDARD
1818
breaking:
19+
ignore_only:
20+
FIELD_SAME_NAME:
21+
- protect/control/v1/
22+
FIELD_SAME_JSON_NAME:
23+
- protect/control/v1/
24+
EXTENSION_NO_DELETE:
25+
- protect/control/v1/
26+
ENUM_VALUE_NO_DELETE:
27+
- protect/control/v1/
28+
FIELD_NO_DELETE:
29+
- protect/control/v1/
1930
use:
31+
- WIRE_JSON
2032
- FILE

protect/control/v1/common.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ enum ZoneState {
183183
ZONE_STATE_CREATING = 1;
184184
ZONE_STATE_CREATED = 2;
185185
ZONE_STATE_READY = 3;
186-
ZONE_STATE_EXITED = 4;
186+
reserved 4;
187+
reserved "ZONE_STATE_EXITED";
187188
ZONE_STATE_DESTROYING = 5;
188189
ZONE_STATE_DESTROYED = 6;
189190
ZONE_STATE_FAILED = 7;

0 commit comments

Comments
 (0)