fix

Author: strengejacke

R/get_contexteffects.R

@@ -12,11 +12,15 @@
   } else {
     dots <- list(...)
     fun_args <- list(model, variables = my_args$contrast, hypothesis = my_args$comparison)
+    # set default for "type" argument, if not provided
     if (is.null(dots$type)) {
       fun_args$type <- "link"
-    }
-    if (is.null(dots$transform)) {
-      fun_args$transform <- "exp"
+      # if "type" was not provided, also change transform argument. we do
+      # this only when user did not provide "type", else - if user provided
+      # "type" - we keep the default NULL
+      if (is.null(dots$transform)) {
+        fun_args$transform <- "exp"
+      }
     }
     out <- do.call(marginaleffects::avg_comparisons, c(fun_args, dots))
   }

tests/testthat/test-estimate_contrasts_context.R

@@ -36,4 +36,11 @@ test_that("estimate_contrast, context effects, glm", {
     comparison = "context"
   )
   expect_equal(out$Estimate, exp(b[1] - b[2]), tolerance = 1e-4, ignore_attr = TRUE)
+  out <- modelbased::estimate_contrasts(
+    m,
+    c("bill_len_between", "bill_len_within"),
+    comparison = "context",
+    type = "response"
+  )
+  expect_equal(out$Estimate, exp(b[1] - b[2]), tolerance = 1e-4, ignore_attr = TRUE)
 })