Skip to content

Commit e5f1ccc

Browse files
authored
SmbShare, UserAccountControl - fix issues with access control parameters, DWord registry value types (#424)
1 parent 1abe0d6 commit e5f1ccc

3 files changed

Lines changed: 7 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323
- AppVeyor build now sets the correct module version to be able to run tests.
2424
- ScheduledTask
2525
- Allowed values for ScheduleType updated to accept AtLogon over AtLogOn - Fixes [Issue #420](https://github.com/dsccommunity/ComputerManagementDsc/issues/420)
26+
- SmbShare
27+
- Allow Test-TargetResource to succeed when access entries use different order - Fixes [Issue #247](https://github.com/dsccommunity/ComputerManagementDsc/issues/247), [Issue #423](https://github.com/dsccommunity/ComputerManagementDsc/issues/423)
28+
- UserAccountControl
29+
- Ensure registry keys are created as REG_DWORD rather than REG_SZ - Fixes [Issue #412](https://github.com/dsccommunity/ComputerManagementDsc/issues/412)
2630

2731
## [9.0.0] - 2023-02-22
2832

source/DSCResources/DSC_SmbShare/DSC_SmbShare.psm1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,7 @@ function Test-TargetResource
531531
$resourceRequiresUpdate = Test-DscParameterState `
532532
-CurrentValues $currentSmbShareConfiguration `
533533
-DesiredValues $PSBoundParameters `
534+
-SortArrayValues `
534535
-Verbose:$VerbosePreference
535536
}
536537
else

source/DSCResources/DSC_UserAccountControl/DSC_UserAccountControl.psm1

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ function Set-TargetResource
225225
Path = $script:registryKey
226226
Name = $parameterName
227227
Value = $PSBoundParameters.$parameterName
228+
Type = 'DWord'
228229
ErrorAction = 'Stop'
229230
}
230231

@@ -533,6 +534,7 @@ function Set-UserAccountControlToNotificationLevel
533534
{
534535
$defaultSetItemPropertyParameters = @{
535536
Path = $script:registryKey
537+
Type = 'DWord'
536538
ErrorAction = 'Stop'
537539
}
538540

0 commit comments

Comments
 (0)