Skip to content

Commit 549476d

Browse files
committed
Fix after PR comments
1 parent 753b77c commit 549476d

1 file changed

Lines changed: 31 additions & 31 deletions

File tree

DSCResources/MSFT_xScheduledTask/MSFT_xScheduledTask.psm1

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -812,23 +812,23 @@ function Set-TargetResource
812812
New-InvalidArgumentException -Message $exceptionMessage -ArgumentName DaysOfWeek
813813
}
814814

815-
$actionArguments = @{
815+
$actionParameters = @{
816816
Execute = $ActionExecutable
817817
}
818818

819819
if ($ActionArguments)
820820
{
821-
$actionArguments.Add('Argument', $ActionArguments)
821+
$actionParameters.Add('Argument', $ActionArguments)
822822
}
823823

824824
if ($ActionWorkingPath)
825825
{
826-
$actionArguments.Add('WorkingDirectory', $ActionWorkingPath)
826+
$actionParameters.Add('WorkingDirectory', $ActionWorkingPath)
827827
}
828828

829-
$action = New-ScheduledTaskAction @actionArguments
829+
$action = New-ScheduledTaskAction @actionParameters
830830

831-
$settingArguments = @{
831+
$settingParameters = @{
832832
DisallowDemandStart = $DisallowDemandStart
833833
DisallowHardTerminate = $DisallowHardTerminate
834834
Compatibility = $Compatibility
@@ -850,89 +850,89 @@ function Set-TargetResource
850850

851851
if ($IdleDuration -gt [System.TimeSpan] '00:00:00')
852852
{
853-
$settingArguments.Add('IdleDuration', $IdleDuration)
853+
$settingParameters.Add('IdleDuration', $IdleDuration)
854854
}
855855

856856
if ($IdleWaitTimeout -gt [System.TimeSpan] '00:00:00')
857857
{
858-
$settingArguments.Add('IdleWaitTimeout', $IdleWaitTimeout)
858+
$settingParameters.Add('IdleWaitTimeout', $IdleWaitTimeout)
859859
}
860860

861861
if ($ExecutionTimeLimit -gt [System.TimeSpan] '00:00:00')
862862
{
863-
$settingArguments.Add('ExecutionTimeLimit', $ExecutionTimeLimit)
863+
$settingParameters.Add('ExecutionTimeLimit', $ExecutionTimeLimit)
864864
}
865865

866866
if ($RestartInterval -gt [System.TimeSpan] '00:00:00')
867867
{
868-
$settingArguments.Add('RestartInterval', $RestartInterval)
868+
$settingParameters.Add('RestartInterval', $RestartInterval)
869869
}
870870

871871
if (-not [System.String]::IsNullOrWhiteSpace($NetworkName))
872872
{
873-
$setting.Add('NetworkName', $NetworkName)
873+
$settingParameters.Add('NetworkName', $NetworkName)
874874
}
875875

876-
$setting = New-ScheduledTaskSettingsSet @settingArguments
876+
$setting = New-ScheduledTaskSettingsSet @settingParameters
877877

878-
$triggerArguments = @{}
878+
$triggerParameters = @{}
879879

880880
if ($RandomDelay -gt [System.TimeSpan]::FromSeconds(0))
881881
{
882-
$triggerArguments.Add('RandomDelay', $RandomDelay)
882+
$triggerParameters.Add('RandomDelay', $RandomDelay)
883883
}
884884

885885
switch ($ScheduleType)
886886
{
887887
'Once'
888888
{
889-
$triggerArguments.Add('Once', $true)
890-
$triggerArguments.Add('At', $StartTime)
889+
$triggerParameters.Add('Once', $true)
890+
$triggerParameters.Add('At', $StartTime)
891891
break
892892
}
893893

894894
'Daily'
895895
{
896-
$triggerArguments.Add('Daily', $true)
897-
$triggerArguments.Add('At', $StartTime)
898-
$triggerArguments.Add('DaysInterval', $DaysInterval)
896+
$triggerParameters.Add('Daily', $true)
897+
$triggerParameters.Add('At', $StartTime)
898+
$triggerParameters.Add('DaysInterval', $DaysInterval)
899899
break
900900
}
901901

902902
'Weekly'
903903
{
904-
$triggerArguments.Add('Weekly', $true)
905-
$triggerArguments.Add('At', $StartTime)
904+
$triggerParameters.Add('Weekly', $true)
905+
$triggerParameters.Add('At', $StartTime)
906906
if ($DaysOfWeek.Count -gt 0)
907907
{
908-
$triggerArguments.Add('DaysOfWeek', $DaysOfWeek)
908+
$triggerParameters.Add('DaysOfWeek', $DaysOfWeek)
909909
}
910910

911911
if ($WeeksInterval -gt 0)
912912
{
913-
$triggerArguments.Add('WeeksInterval', $WeeksInterval)
913+
$triggerParameters.Add('WeeksInterval', $WeeksInterval)
914914
}
915915
break
916916
}
917917

918918
'AtStartup'
919919
{
920-
$triggerArguments.Add('AtStartup', $true)
920+
$triggerParameters.Add('AtStartup', $true)
921921
break
922922
}
923923

924924
'AtLogOn'
925925
{
926-
$triggerArguments.Add('AtLogOn', $true)
926+
$triggerParameters.Add('AtLogOn', $true)
927927
if (-not [System.String]::IsNullOrWhiteSpace($User))
928928
{
929-
$triggerArguments.Add('User', $User)
929+
$triggerParameters.Add('User', $User)
930930
}
931931
break
932932
}
933933
}
934934

935-
$trigger = New-ScheduledTaskTrigger @triggerArguments -ErrorAction SilentlyContinue
935+
$trigger = New-ScheduledTaskTrigger @triggerParameters -ErrorAction SilentlyContinue
936936

937937
if (-not $trigger)
938938
{
@@ -951,7 +951,7 @@ function Set-TargetResource
951951
New-InvalidArgumentException -Message $exceptionMessage -ArgumentName RepetitionDuration
952952
}
953953

954-
$tempTriggerArguments = @{
954+
$temptriggerParameters = @{
955955
Once = $true
956956
At = '6:6:6'
957957
RepetitionInterval = $RepeatInterval
@@ -966,10 +966,10 @@ function Set-TargetResource
966966
# This is the type of trigger object returned in Windows Server 2012 R2/Windows 8.1 and below
967967
Write-Verbose -Message ('Creating temporary task and trigger to get MSFT_TaskRepetitionPattern CIM instance.')
968968

969-
$tempTriggerArguments.Add('RepetitionDuration', $RepetitionDuration)
969+
$tempTriggerParameters.Add('RepetitionDuration', $RepetitionDuration)
970970

971971
# Create a temporary trigger and task and copy the repetition CIM object from the temporary task
972-
$tempTrigger = New-ScheduledTaskTrigger @tempTriggerArguments
972+
$tempTrigger = New-ScheduledTaskTrigger @tempTriggerParameters
973973
$tempTask = New-ScheduledTask -Action $action -Trigger $tempTrigger
974974

975975
# Store the repetition settings
@@ -983,11 +983,11 @@ function Set-TargetResource
983983

984984
if ($RepetitionDuration -gt [System.TimeSpan]::Parse('0:0:0') -and $RepetitionDuration -lt [System.TimeSpan]::MaxValue)
985985
{
986-
$tempTriggerArguments.Add('RepetitionDuration', $RepetitionDuration)
986+
$tempTriggerParameters.Add('RepetitionDuration', $RepetitionDuration)
987987
}
988988

989989
# Create a temporary trigger and copy the repetition CIM object from it to the actual trigger
990-
$tempTrigger = New-ScheduledTaskTrigger @tempTriggerArguments
990+
$tempTrigger = New-ScheduledTaskTrigger @tempTriggerParameters
991991

992992
# Store the repetition settings
993993
$repetition = $tempTrigger.Repetition

0 commit comments

Comments
 (0)