Merge pull request #7 from gesbeckj/xDescription

Added Check to Avoid returning false and setting the description if i…

Author: gesbeckj

DSCResources/MSFT_xComputer/MSFT_xComputer.psm1

@@ -117,11 +117,13 @@ function Set-TargetResource
         $Name = $env:COMPUTERNAME
     }
 
-    Write-Verbose -Message "Setting computer description to '$($Description)'."
-    $win32OperatingSystemCimInstance = Get-CimInstance -ClassName Win32_OperatingSystem
-    $win32OperatingSystemCimInstance.Description = $Description
-    Set-CimInstance -InputObject $win32OperatingSystemCimInstance
-
+    if ($PSBoundParameters.ContainsKey('Description'))
+    {
+        Write-Verbose -Message "Setting computer description to '$($Description)'."
+        $win32OperatingSystemCimInstance = Get-CimInstance -ClassName Win32_OperatingSystem
+        $win32OperatingSystemCimInstance.Description = $Description
+        Set-CimInstance -InputObject $win32OperatingSystemCimInstance
+    }
     if ($Credential)
     {
         if ($DomainName)
@@ -303,13 +305,14 @@ function Test-TargetResource
         return $false
     }
 
-    Write-Verbose -Message 'Checking if description is corerect'
-
-    if ($Description -ne (Get-CimInstance -Class 'Win32_OperatingSystem').Description)
+    if ($PSBoundParameters.ContainsKey('Description'))
     {
-        return $false
+        Write-Verbose -Message 'Checking if description is corerect'
+        if ($Description -ne (Get-CimInstance -Class 'Win32_OperatingSystem').Description)
+        {
+            return $false
+        }
     }
-
     Assert-DomainOrWorkGroup -DomainName $DomainName -WorkGroupName $WorkGroupName
 
     if ($DomainName)

Tests/Unit/MSFT_xComputer.Tests.ps1

@@ -556,7 +556,7 @@ try
                     }
                     Set-TargetResource -Name $env:ComputerName | Should BeNullOrEmpty
                     Set-TargetResource -Name $env:COMPUTERNAME -DomainName 'Contoso.com' -Credential $Credential -UnjoinCredential $Credential  -Description 'This is my computer' | Should BeNullOrEmpty
-                    Assert-MockCalled -CommandName Set-CimInstance -Exactly -Times 2 -Scope It
+                    Assert-MockCalled -CommandName Set-CimInstance -Exactly -Times 1 -Scope It
                 }
             }
         }