Final tweaks to meet HQRM for TimeZone

Author: PlagueHO

Modules/ComputerManagementDsc/Modules/ComputerManagementDsc.Common/ComputerManagementDsc.Common.psm1

@@ -364,11 +364,10 @@ function Get-TimeZoneId
                 -Namespace root\cimv2).StandardName
     }
 
-    Write-Verbose -Message ($LocalizedData.CurrentTimeZoneMessage `
-            -f $timeZone)
+    Write-Verbose -Message ($LocalizedData.CurrentTimeZoneMessage -f $timeZone)
 
     $timeZoneInfo = [System.TimeZoneInfo]::GetSystemTimeZones() |
-        Where-Object StandardName -eq $timeZone
+        Where-Object -Property StandardName -EQ $timeZone
 
     return $timeZoneInfo.Id
 } # function Get-TimeZoneId
@@ -422,16 +421,14 @@ function Set-TimeZoneId
         if (Test-Command -Name 'Add-Type' -Module 'Microsoft.Powershell.Utility')
         {
             # We can use reflection to modify the time zone.
-            Write-Verbose -Message ($LocalizedData.SettingTimeZoneMessage `
-                    -f $TimeZoneId, '.NET')
+            Write-Verbose -Message ($LocalizedData.SettingTimeZoneMessage -f $TimeZoneId, '.NET')
 
             Set-TimeZoneUsingDotNet -TimeZoneId $TimeZoneId
         }
         else
         {
             # For anything else use TZUTIL.EXE.
-            Write-Verbose -Message ($LocalizedData.SettingTimeZoneMessage `
-                    -f $TimeZoneId, 'TZUTIL.EXE')
+            Write-Verbose -Message ($LocalizedData.SettingTimeZoneMessage -f $TimeZoneId, 'TZUTIL.EXE')
 
             try
             {
@@ -444,8 +441,7 @@ function Set-TimeZoneId
         } # if
     } # if
 
-    Write-Verbose -Message ($LocalizedData.TimeZoneUpdatedMessage `
-            -f $TimeZoneId)
+    Write-Verbose -Message ($LocalizedData.TimeZoneUpdatedMessage -f $TimeZoneId)
 } # function Set-TimeZoneId
 
 <#

Tests/Integration/MSFT_TimeZone.Integration.Tests.ps1

@@ -54,20 +54,20 @@ try
                     -Verbose `
                     -Force `
                     -ErrorAction Stop
-            } | Should Not Throw
+            } | Should -Not -Throw
         }
 
         It 'Should be able to call Get-DscConfiguration without throwing' {
-            { Get-DscConfiguration -Verbose -ErrorAction Stop } | Should Not Throw
+            { Get-DscConfiguration -Verbose -ErrorAction Stop } | Should -Not -Throw
         }
         #endregion
 
         It 'Should have set the configuration and all the parameters should match' {
-            $current = Get-DscConfiguration | Where-Object {
+            $current = Get-DscConfiguration | Where-Object -FilterScript {
                 $_.ConfigurationName -eq "$($script:DSCResourceName)_Config"
             }
-            $current.TimeZone         | Should Be $configData.AllNodes[0].TimeZone
-            $current.IsSingleInstance | Should Be $configData.AllNodes[0].IsSingleInstance
+            $current.TimeZone         | Should -Be $configData.AllNodes[0].TimeZone
+            $current.IsSingleInstance | Should -Be $configData.AllNodes[0].IsSingleInstance
         }
     }
     #endregion

Tests/Unit/MSFT_TimeZone.Tests.ps1

@@ -46,17 +46,17 @@ try
                 -CommandName Get-TimeZoneId `
                 -MockWith { 'Pacific Standard Time' }
 
-            $TimeZone = Get-TargetResource `
+            $timeZone = Get-TargetResource `
                 -TimeZone 'Pacific Standard Time' `
                 -IsSingleInstance 'Yes' `
                 -Verbose
 
             It 'Should return hashtable with Key TimeZone' {
-                $TimeZone.ContainsKey('TimeZone') | Should -Be $true
+                $timeZone.ContainsKey('TimeZone') | Should -Be $true
             }
 
             It 'Should return hashtable with Value that matches "Pacific Standard Time"' {
-                $TimeZone.TimeZone = 'Pacific Standard Time'
+                $timeZone.TimeZone = 'Pacific Standard Time'
             }
         }
 
@@ -80,13 +80,13 @@ try
             }
 
             It 'Should not call Set-TimeZoneId when Current TimeZone already set to desired State' {
-                $SystemTimeZone = Get-TargetResource `
+                $systemTimeZone = Get-TargetResource `
                     -TimeZone 'Eastern Standard Time' `
                     -IsSingleInstance 'Yes' `
                     -Verbose
 
                 Set-TargetResource `
-                    -TimeZone $SystemTimeZone.TimeZone `
+                    -TimeZone $systemTimeZone.TimeZone `
                     -IsSingleInstance 'Yes' `
                     -Verbose