Skip to content

Commit 1c0140d

Browse files
PlagueHOPlagueHO
committed
Correct unit tests for Common
1 parent ab066c4 commit 1c0140d

2 files changed

Lines changed: 125 additions & 69 deletions

File tree

‎Modules/ComputerManagementDsc/Modules/ComputerManagementDsc.Common/ComputerManagementDsc.Common.psm1‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Import the Networking Resource Helper Module
1+
# Import the ComputerManagement Resource Helper Module
22
Import-Module -Name (Join-Path -Path (Split-Path -Path $PSScriptRoot -Parent) `
33
-ChildPath (Join-Path -Path 'ComputerManagementDsc.ResourceHelper' `
44
-ChildPath 'ComputerManagementDsc.ResourceHelper.psm1'))

‎Tests/Unit/ComputerManagementDsc.Common.Tests.ps1‎

Lines changed: 124 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -443,9 +443,12 @@ try
443443

444444
Describe 'ComputerManagementDsc.Common\Get-TimeZoneId' {
445445
Context '"Get-TimeZone" not available and current timezone is set to "Pacific Standard Time"' {
446-
Mock -CommandName Get-Command -ParameterFilter {
447-
$Name -eq 'Get-TimeZone'
448-
}
446+
Mock `
447+
-CommandName Get-Command `
448+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
449+
-ParameterFilter {
450+
$Name -eq 'Get-TimeZone'
451+
}
449452

450453
Mock -CommandName Get-CimInstance -MockWith {
451454
@{
@@ -458,18 +461,24 @@ try
458461
}
459462

460463
It 'Should call expected mocks' {
461-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
462-
$Name -eq 'Get-TimeZone'
463-
} -Exactly -Times 1
464+
Assert-MockCalled `
465+
-CommandName Get-Command `
466+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
467+
-ParameterFilter {
468+
$Name -eq 'Get-TimeZone'
469+
} -Exactly -Times 1
464470

465471
Assert-MockCalled -CommandName Get-CimInstance -Exactly -Times 1
466472
}
467473
}
468474

469475
Context '"Get-TimeZone" not available and current timezone is set to "Russia TZ 11 Standard Time"' {
470-
Mock -CommandName Get-Command -ParameterFilter {
471-
$Name -eq 'Get-TimeZone'
472-
}
476+
Mock `
477+
-CommandName Get-Command `
478+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
479+
-ParameterFilter {
480+
$Name -eq 'Get-TimeZone'
481+
}
473482

474483
Mock -CommandName Get-CimInstance -MockWith {
475484
@{
@@ -482,9 +491,12 @@ try
482491
}
483492

484493
It 'Should call expected mocks' {
485-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
486-
$Name -eq 'Get-TimeZone'
487-
} -Exactly -Times 1
494+
Assert-MockCalled `
495+
-CommandName Get-Command `
496+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
497+
-ParameterFilter {
498+
$Name -eq 'Get-TimeZone'
499+
} -Exactly -Times 1
488500

489501
Assert-MockCalled -CommandName Get-CimInstance -Exactly -Times 1
490502
}
@@ -495,34 +507,42 @@ try
495507
{
496508
}
497509

498-
Mock -CommandName Get-Command -ParameterFilter {
499-
$Name -eq 'Get-TimeZone'
500-
} -MockWith {
501-
'Get-TimeZone'
502-
}
510+
Mock `
511+
-CommandName Get-Command `
512+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
513+
-ParameterFilter {
514+
$Name -eq 'Get-TimeZone'
515+
} -MockWith {
516+
'Get-TimeZone'
517+
}
503518

504-
Mock -CommandName Get-TimeZone -MockWith {
505-
@{
506-
StandardName = 'Pacific Standard Time'
519+
Mock `
520+
-CommandName Get-TimeZone `
521+
-MockWith {
522+
@{
523+
StandardName = 'Pacific Standard Time'
524+
}
507525
}
508-
}
509526

510527
It 'Returns "Pacific Standard Time"' {
511528
Get-TimeZoneId | Should -Be 'Pacific Standard Time'
512529
}
513530

514531
It 'Should call expected mocks' {
515-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
516-
$Name -eq 'Get-TimeZone'
517-
} -Exactly -Times 1
532+
Assert-MockCalled `
533+
-CommandName Get-Command `
534+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
535+
-ParameterFilter {
536+
$Name -eq 'Get-TimeZone'
537+
} -Exactly -Times 1
518538

519539
Assert-MockCalled -CommandName Get-TimeZone -Exactly -Times 1
520540
}
521541
}
522542
}
523543

524544
Describe 'ComputerManagementDsc.Common\Test-TimezoneId' {
525-
Mock Get-TimeZoneId -MockWith {
545+
Mock -CommandName Get-TimeZoneId -MockWith {
526546
'Russia Time Zone 11'
527547
}
528548

@@ -541,13 +561,19 @@ try
541561

542562
Describe 'ComputerManagementDsc.Common\Set-TimeZoneId' {
543563
Context '"Set-TimeZone" and "Add-Type" is not available, Tzutil Returns 0' {
544-
Mock -CommandName Get-Command -ParameterFilter {
545-
$Name -eq 'Add-Type'
546-
}
564+
Mock `
565+
-CommandName Get-Command `
566+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
567+
-ParameterFilter {
568+
$Name -eq 'Add-Type'
569+
}
547570

548-
Mock -CommandName Get-Command -ParameterFilter {
549-
$Name -eq 'Set-TimeZone'
550-
}
571+
Mock `
572+
-CommandName Get-Command `
573+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
574+
-ParameterFilter {
575+
$Name -eq 'Set-TimeZone'
576+
}
551577

552578
Mock -CommandName 'TzUtil.exe' -MockWith {
553579
$global:LASTEXITCODE = 0
@@ -561,29 +587,41 @@ try
561587
}
562588

563589
It 'Should call expected mocks' {
564-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
565-
$Name -eq 'Add-Type'
566-
} -Exactly -Times 1
567-
568-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
569-
$Name -eq 'Set-TimeZone'
570-
} -Exactly -Times 1
590+
Assert-MockCalled `
591+
-CommandName Get-Command `
592+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
593+
-ParameterFilter {
594+
$Name -eq 'Add-Type'
595+
} -Exactly -Times 1
596+
597+
Assert-MockCalled `
598+
-CommandName Get-Command `
599+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
600+
-ParameterFilter {
601+
$Name -eq 'Set-TimeZone'
602+
} -Exactly -Times 1
571603

572604
Assert-MockCalled -CommandName TzUtil.exe -Exactly -Times 1
573605
Assert-MockCalled -CommandName Add-Type -Exactly -Times 0
574606
}
575607
}
576608

577609
Context '"Set-TimeZone" is not available but "Add-Type" is available' {
578-
Mock -CommandName Get-Command -ParameterFilter {
579-
$Name -eq 'Add-Type'
580-
} -MockWith {
581-
'Add-Type'
582-
}
610+
Mock `
611+
-CommandName Get-Command `
612+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
613+
-ParameterFilter {
614+
$Name -eq 'Add-Type'
615+
} -MockWith {
616+
'Add-Type'
617+
}
583618

584-
Mock -CommandName Get-Command -ParameterFilter {
585-
$Name -eq 'Set-TimeZone'
586-
}
619+
Mock `
620+
-CommandName Get-Command `
621+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
622+
-ParameterFilter {
623+
$Name -eq 'Set-TimeZone'
624+
}
587625

588626
Mock -CommandName 'TzUtil.exe' -MockWith {
589627
$global:LASTEXITCODE = 0
@@ -598,13 +636,19 @@ try
598636
}
599637

600638
It 'Should call expected mocks' {
601-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
602-
$Name -eq 'Add-Type'
603-
} -Exactly -Times 1
604-
605-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
606-
$Name -eq 'Set-TimeZone'
607-
} -Exactly -Times 1
639+
Assert-MockCalled `
640+
-CommandName Get-Command `
641+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
642+
-ParameterFilter {
643+
$Name -eq 'Add-Type'
644+
} -Exactly -Times 1
645+
646+
Assert-MockCalled `
647+
-CommandName Get-Command `
648+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
649+
-ParameterFilter {
650+
$Name -eq 'Set-TimeZone'
651+
} -Exactly -Times 1
608652

609653
Assert-MockCalled -CommandName TzUtil.exe -Exactly -Times 0
610654
Assert-MockCalled -CommandName Add-Type -Exactly -Times 0
@@ -622,15 +666,21 @@ try
622666
)
623667
}
624668

625-
Mock -CommandName Get-Command -ParameterFilter {
626-
$Name -eq 'Add-Type'
627-
}
669+
Mock `
670+
-CommandName Get-Command `
671+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
672+
-ParameterFilter {
673+
$Name -eq 'Add-Type'
674+
}
628675

629-
Mock -CommandName Get-Command -ParameterFilter {
630-
$Name -eq 'Set-TimeZone'
631-
} -MockWith {
632-
'Set-TimeZone'
633-
}
676+
Mock `
677+
-CommandName Get-Command `
678+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
679+
-ParameterFilter {
680+
$Name -eq 'Set-TimeZone'
681+
} -MockWith {
682+
'Set-TimeZone'
683+
}
634684

635685
Mock -CommandName Set-TimeZone
636686

@@ -639,13 +689,19 @@ try
639689
}
640690

641691
It 'Should call expected mocks' {
642-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
643-
$Name -eq 'Add-Type'
644-
} -Exactly -Times 0
645-
646-
Assert-MockCalled -CommandName Get-Command -ParameterFilter {
647-
$Name -eq 'Set-TimeZone'
648-
} -Exactly -Times 1
692+
Assert-MockCalled `
693+
-CommandName Get-Command `
694+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
695+
-ParameterFilter {
696+
$Name -eq 'Add-Type'
697+
} -Exactly -Times 0
698+
699+
Assert-MockCalled `
700+
-CommandName Get-Command `
701+
-ModuleName 'ComputerManagementDsc.ResourceHelper' `
702+
-ParameterFilter {
703+
$Name -eq 'Set-TimeZone'
704+
} -Exactly -Times 1
649705

650706
Assert-MockCalled -CommandName Set-TimeZone -Exactly -Times 1
651707
}

0 commit comments

Comments
 (0)