Minor code clean up

Author: commonsensesoftware

src/Abstractions/src/Asp.Versioning.Abstractions/NamespaceParser.cs

@@ -18,9 +18,9 @@ namespace Asp.Versioning;
 /// Represents API version parser from a type namespace.
 /// </summary>
 /// <remarks>
-/// The namespace identifier can use 'v', 'V', or '_' as a prefix. The '_' prefix is useful when
-/// a folder starts with a number because Visual Studio automatically prefixes it with an underscore.
-/// For example, <c>Contoso.Api._2018_04_01.Controllers</c> is equivalent to <c>Contoso.Api.v2018_04_01.Controllers</c>.
+/// The namespace identifier can use <c>'v'</c>, <c>'V'</c>, or <c>'_'</c> as a prefix. The <c>'_'</c> prefix is useful
+/// when the source folder starts with a number and the editor automatically prefixes it with an underscore. As an
+/// example, <c>Api._2018_04_01.Controllers</c> is equivalent to <c>Api.v2018_04_01.Controllers</c>.
 /// </remarks>
 public class NamespaceParser
 {

src/AspNetCore/WebApi/src/Asp.Versioning.Mvc.ApiExplorer/DependencyInjection/IApiVersioningBuilderExtensions.cs

@@ -58,12 +58,8 @@ private static void AddApiExplorerServices( IApiVersioningBuilder builder )
 
         var services = builder.Services;
 
-        // registers DefaultApiDescriptionProvider, which discovers controller-based endpoints
-        services.AddMvcCore().AddApiExplorer();
-
-        // registers EndpointMetadataApiDescriptionProvider, which discovers minimal API endpoints.
-        // both providers are required so that OpenApiDocumentService sees all endpoints.
         services.AddEndpointsApiExplorer();
+        services.AddMvcCore().AddApiExplorer();
         services.TryAddSingleton<IOptionsFactory<ApiExplorerOptions>, ApiExplorerOptionsFactory<ApiExplorerOptions>>();
         services.TryAddTransient<IApiVersionDescriptionProviderFactory, ApiVersionDescriptionProviderFactory>();
         services.TryAddSingleton( static sp => sp.GetRequiredService<IApiVersionDescriptionProviderFactory>().Create() );

src/AspNetCore/WebApi/test/Asp.Versioning.OpenApi.Tests/Asp.Versioning.OpenApi.Tests.csproj

@@ -13,7 +13,7 @@
  </ItemGroup>
 
  <ItemGroup>
-  <Compile Include="$(SourceFile)" Condition="Exists('$(SourceFile)')" Link="%(Filename)%(Extension)" Visible="false" />
+  <Compile Include="$(RootDir)\src\Abstractions\test\Asp.Versioning.Abstractions.Tests\AssumeCultureAttribute.cs" Link="AssumeCultureAttribute.cs" />
  </ItemGroup>
 
  <ItemGroup>
@@ -35,7 +35,7 @@
   <WriteLinesToFile File="$(SourceFile)" Lines="@(Code)" Overwrite="true" />
 
   <ItemGroup>
-   <Compile Include="$(SourceFile)" Visible="false" />
+   <Compile Include="$(SourceFile)" />
   </ItemGroup>
 
  </Target>

src/AspNetCore/WebApi/test/Asp.Versioning.OpenApi.Tests/AssumeCultureAttribute.cs

@@ -13,13 +13,6 @@ namespace Asp.Versioning.OpenApi.Transformers;
 
 public class AcceptanceTest
 {
-    /// <summary>
-    /// Verifies that minimal API endpoints produce a non-empty OpenAPI document.
-    /// <c>AddApiExplorer</c> internally calls <c>AddMvcCore().AddApiExplorer()</c>,
-    /// which auto-discovers controllers from the test assembly. Application parts
-    /// are cleared to isolate the test to minimal API endpoints only.
-    /// </summary>
-    /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
     [Fact]
     [AssumeCulture( "en-US" )]
     public async Task minimal_api_should_generate_expected_open_api_document()
@@ -31,9 +24,8 @@ public async Task minimal_api_should_generate_expected_open_api_document()
         builder.Services.AddApiVersioning( options => AddPolicies( options ) )
                         .AddApiExplorer( options => options.GroupNameFormat = "'v'VVV" )
                         .AddOpenApi();
-        builder.Services.AddMvcCore()
-                        .ConfigureApplicationPartManager(
-                            m => m.ApplicationParts.Clear() );
+
+        IsolateMinimalApis( builder.Services );
 
         var app = builder.Build();
         var api = app.NewVersionedApi( "Test" )
@@ -133,6 +125,9 @@ public async Task mixed_api_should_generate_expected_open_api_document()
         JsonNode.DeepEquals( actual, expected ).Should().BeTrue();
     }
 
+    private static void IsolateMinimalApis( IServiceCollection services ) =>
+        services.AddMvcCore().ConfigureApplicationPartManager( m => m.ApplicationParts.Clear() );
+
     private static ApiVersioningOptions AddPolicies( ApiVersioningOptions options )
     {
         options.Policies.Deprecate( 1.0 )