Skip to content

Commit b8c70b6

Browse files
authored
Merge pull request #830 from doringeman/tmp-fix-vllm-metal
fix(vllm-metal): suppress -Wparentheses for Apple Clang 21 build
2 parents 2d92a49 + 380ce46 commit b8c70b6

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

scripts/build-vllm-metal-tarball.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ curl -fsSL -O "https://github.com/vllm-project/vllm/releases/download/v$VLLM_VER
5757
tar xf "vllm-$VLLM_VERSION.tar.gz"
5858
cd "vllm-$VLLM_VERSION"
5959
uv pip install --python "$PYTHON_DIR/bin/python3" --system -r requirements/cpu.txt --index-strategy unsafe-best-match
60-
uv pip install --python "$PYTHON_DIR/bin/python3" --system .
60+
# TODO: remove -Wno-parentheses once vllm-project/vllm#38801 is in a release and VLLM_VERSION is bumped past it.
61+
# Apple Clang 21 (Xcode 26+) promotes -Wparentheses to an error for chained comparisons like `0 < M <= 8` in
62+
# vllm's CPU attention headers. Clang 17 (Xcode 16.x, used in CI) only warns.
63+
CXXFLAGS="-Wno-parentheses" uv pip install --python "$PYTHON_DIR/bin/python3" --system .
6164
cd "$WORK_DIR"
6265
rm -rf "vllm-$VLLM_VERSION" "vllm-$VLLM_VERSION.tar.gz"
6366

0 commit comments

Comments
 (0)