linting: address assorted issues found by gocritic

thaJeztah · thaJeztah · commit 888df09879e8 · 2023-11-20T16:02:16.000+01:00
internal/test/builders/config.go:36:15: captLocal: `ID' should not be capitalized (gocritic)
    func ConfigID(ID string) func(config *swarm.Config) {
                  ^
    internal/test/builders/secret.go:45:15: captLocal: `ID' should not be capitalized (gocritic)
    func SecretID(ID string) func(secret *swarm.Secret) {
                  ^
    internal/test/builders/service.go:21:16: captLocal: `ID' should not be capitalized (gocritic)
    func ServiceID(ID string) func(*swarm.Service) {
                   ^
    cli/command/image/formatter_history.go:100:15: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(c.h.CreatedBy, "\t", " ", -1)` (gocritic)
        createdBy := strings.Replace(c.h.CreatedBy, "\t", " ", -1)
                     ^
    e2e/image/push_test.go:246:34: badCall: suspicious Join on 1 argument (gocritic)
        assert.NilError(t, os.RemoveAll(filepath.Join(dir.Join("trust"))))
                                        ^
    e2e/image/push_test.go:313:34: badCall: suspicious Join on 1 argument (gocritic)
        assert.NilError(t, os.RemoveAll(filepath.Join(dir.Join("trust"))))
                                        ^
    cli/config/configfile/file_test.go:185:2: assignOp: replace `c.GetAllCallCount = c.GetAllCallCount + 1` with `c.GetAllCallCount++` (gocritic)
        c.GetAllCallCount = c.GetAllCallCount + 1
        ^
    cli/command/context/inspect_test.go:20:58: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(si.MetadataPath, `\`, `\\`, -1)` (gocritic)
        expected = strings.Replace(expected, "&lt;METADATA_PATH&gt;", strings.Replace(si.MetadataPath, `\`, `\\`, -1), 1)
                                                                ^
    cli/command/context/inspect_test.go:21:53: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(si.TLSPath, `\`, `\\`, -1)` (gocritic)
        expected = strings.Replace(expected, "&lt;TLS_PATH&gt;", strings.Replace(si.TLSPath, `\`, `\\`, -1), 1)
                                                           ^
    cli/command/container/formatter_stats.go:119:46: captLocal: `Stats' should not be capitalized (gocritic)
    func statsFormatWrite(ctx formatter.Context, Stats []StatsEntry, osType string, trunc bool) error {
                                                 ^
    cli/command/container/stats_helpers.go:209:4: assignOp: replace `blkRead = blkRead + bioEntry.Value` with `blkRead += bioEntry.Value` (gocritic)
                blkRead = blkRead + bioEntry.Value
                ^
    cli/command/container/stats_helpers.go:211:4: assignOp: replace `blkWrite = blkWrite + bioEntry.Value` with `blkWrite += bioEntry.Value` (gocritic)
                blkWrite = blkWrite + bioEntry.Value
                ^
    cli/command/registry/formatter_search.go:67:10: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(c.s.Description, "\n", " ", -1)` (gocritic)
        desc := strings.Replace(c.s.Description, "\n", " ", -1)
                ^
    cli/command/registry/formatter_search.go:68:9: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(desc, "\r", " ", -1)` (gocritic)
        desc = strings.Replace(desc, "\r", " ", -1)
               ^
    cli/command/service/list_test.go:164:5: assignOp: replace `tc.doc = tc.doc + " with quiet"` with `tc.doc += " with quiet"` (gocritic)
                    tc.doc = tc.doc + " with quiet"
                    ^
    cli/command/service/progress/progress.go:274:11: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(errMsg, "\n", " ", -1)` (gocritic)
        errMsg = strings.Replace(errMsg, "\n", " ", -1)
                 ^
    cli/manifest/store/store.go:153:9: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(fileName, "/", "_", -1)` (gocritic)
        return strings.Replace(fileName, "/", "_", -1)
               ^
    cli/manifest/store/store.go:152:14: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(ref, ":", "-", -1)` (gocritic)
        fileName := strings.Replace(ref, ":", "-", -1)
                    ^
    cli/command/plugin/formatter.go:79:10: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(c.p.Config.Description, "\n", "", -1)` (gocritic)
        desc := strings.Replace(c.p.Config.Description, "\n", "", -1)
                ^
    cli/command/plugin/formatter.go:80:9: wrapperFunc: use strings.ReplaceAll method in `strings.Replace(desc, "\r", "", -1)` (gocritic)
        desc = strings.Replace(desc, "\r", "", -1)
               ^
    cli/compose/convert/service.go:642:23: captLocal: `DNS' should not be capitalized (gocritic)
    func convertDNSConfig(DNS []string, DNSSearch []string) *swarm.DNSConfig {
                          ^

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/container/formatter_stats.go b/cli/command/container/formatter_stats.go
@@ -116,9 +116,9 @@ func NewStats(container string) *Stats {
 }
 
 // statsFormatWrite renders the context for a list of containers statistics
-func statsFormatWrite(ctx formatter.Context, Stats []StatsEntry, osType string, trunc bool) error {
+func statsFormatWrite(ctx formatter.Context, stats []StatsEntry, osType string, trunc bool) error {
 	render := func(format func(subContext formatter.SubContext) error) error {
-		for _, cstats := range Stats {
+		for _, cstats := range stats {
 			statsCtx := &statsContext{
 				s:     cstats,
 				os:    osType,
diff --git a/cli/command/container/stats_helpers.go b/cli/command/container/stats_helpers.go
@@ -206,9 +206,9 @@ func calculateBlockIO(blkio types.BlkioStats) (uint64, uint64) {
 		}
 		switch bioEntry.Op[0] {
 		case 'r', 'R':
-			blkRead = blkRead + bioEntry.Value
+			blkRead += bioEntry.Value
 		case 'w', 'W':
-			blkWrite = blkWrite + bioEntry.Value
+			blkWrite += bioEntry.Value
 		}
 	}
 	return blkRead, blkWrite
diff --git a/cli/command/context/inspect_test.go b/cli/command/context/inspect_test.go
@@ -17,7 +17,7 @@ func TestInspect(t *testing.T) {
 	}))
 	expected := string(golden.Get(t, "inspect.golden"))
 	si := cli.ContextStore().GetStorageInfo("current")
-	expected = strings.Replace(expected, "<METADATA_PATH>", strings.Replace(si.MetadataPath, `\`, `\\`, -1), 1)
-	expected = strings.Replace(expected, "<TLS_PATH>", strings.Replace(si.TLSPath, `\`, `\\`, -1), 1)
+	expected = strings.Replace(expected, "<METADATA_PATH>", strings.ReplaceAll(si.MetadataPath, `\`, `\\`), 1)
+	expected = strings.Replace(expected, "<TLS_PATH>", strings.ReplaceAll(si.TLSPath, `\`, `\\`), 1)
 	assert.Equal(t, cli.OutBuffer().String(), expected)
 }
diff --git a/cli/command/image/formatter_history.go b/cli/command/image/formatter_history.go
@@ -97,7 +97,7 @@ func (c *historyContext) CreatedSince() string {
 }
 
 func (c *historyContext) CreatedBy() string {
-	createdBy := strings.Replace(c.h.CreatedBy, "\t", " ", -1)
+	createdBy := strings.ReplaceAll(c.h.CreatedBy, "\t", " ")
 	if c.trunc {
 		return formatter.Ellipsis(createdBy, 45)
 	}
diff --git a/cli/command/plugin/formatter.go b/cli/command/plugin/formatter.go
@@ -76,8 +76,8 @@ func (c *pluginContext) Name() string {
 }
 
 func (c *pluginContext) Description() string {
-	desc := strings.Replace(c.p.Config.Description, "\n", "", -1)
-	desc = strings.Replace(desc, "\r", "", -1)
+	desc := strings.ReplaceAll(c.p.Config.Description, "\n", "")
+	desc = strings.ReplaceAll(desc, "\r", "")
 	if c.trunc {
 		desc = formatter.Ellipsis(desc, 45)
 	}
diff --git a/cli/command/registry/formatter_search.go b/cli/command/registry/formatter_search.go
@@ -64,8 +64,8 @@ func (c *searchContext) Name() string {
 }
 
 func (c *searchContext) Description() string {
-	desc := strings.Replace(c.s.Description, "\n", " ", -1)
-	desc = strings.Replace(desc, "\r", " ", -1)
+	desc := strings.ReplaceAll(c.s.Description, "\n", " ")
+	desc = strings.ReplaceAll(desc, "\r", " ")
 	if c.trunc {
 		desc = formatter.Ellipsis(desc, 45)
 	}
diff --git a/cli/command/service/list_test.go b/cli/command/service/list_test.go
@@ -161,7 +161,7 @@ func TestServiceListServiceStatus(t *testing.T) {
 		for _, tc := range tests {
 			if quiet {
 				tc.withQuiet = quiet
-				tc.doc = tc.doc + " with quiet"
+				tc.doc += " with quiet"
 			}
 			matrix = append(matrix, tc)
 		}
diff --git a/cli/command/service/progress/progress.go b/cli/command/service/progress/progress.go
@@ -271,7 +271,7 @@ func writeOverallProgress(progressOut progress.Output, numerator, denominator in
 
 func truncError(errMsg string) string {
 	// Remove newlines from the error, which corrupt the output.
-	errMsg = strings.Replace(errMsg, "\n", " ", -1)
+	errMsg = strings.ReplaceAll(errMsg, "\n", " ")
 
 	// Limit the length to 75 characters, so that even on narrow terminals
 	// this will not overflow to the next line.
diff --git a/cli/compose/convert/service.go b/cli/compose/convert/service.go
@@ -639,11 +639,11 @@ func convertDeployMode(mode string, replicas *uint64) (swarm.ServiceMode, error)
 	return serviceMode, nil
 }
 
-func convertDNSConfig(DNS []string, DNSSearch []string) *swarm.DNSConfig {
-	if DNS != nil || DNSSearch != nil {
+func convertDNSConfig(dns []string, dnsSearch []string) *swarm.DNSConfig {
+	if dns != nil || dnsSearch != nil {
 		return &swarm.DNSConfig{
-			Nameservers: DNS,
-			Search:      DNSSearch,
+			Nameservers: dns,
+			Search:      dnsSearch,
 		}
 	}
 	return nil
diff --git a/cli/config/configfile/file_test.go b/cli/config/configfile/file_test.go
@@ -182,7 +182,7 @@ func (c *mockNativeStore) Get(registryHostname string) (types.AuthConfig, error)
 }
 
 func (c *mockNativeStore) GetAll() (map[string]types.AuthConfig, error) {
-	c.GetAllCallCount = c.GetAllCallCount + 1
+	c.GetAllCallCount++
 	return c.authConfigs, nil
 }
 
diff --git a/cli/manifest/store/store.go b/cli/manifest/store/store.go
@@ -149,8 +149,8 @@ func manifestToFilename(root, manifestList, manifest string) string {
 }
 
 func makeFilesafeName(ref string) string {
-	fileName := strings.Replace(ref, ":", "-", -1)
-	return strings.Replace(fileName, "/", "_", -1)
+	fileName := strings.ReplaceAll(ref, ":", "-")
+	return strings.ReplaceAll(fileName, "/", "_")
 }
 
 type notFoundError struct {
diff --git a/e2e/image/push_test.go b/e2e/image/push_test.go
@@ -3,7 +3,6 @@ package image
 import (
 	"fmt"
 	"os"
-	"path/filepath"
 	"strings"
 	"testing"
 
@@ -243,7 +242,7 @@ func TestPushWithContentTrustSignsAllFirstLevelRolesWeHaveKeysFor(t *testing.T)
 	targetsInRole = notaryListTargetsInRole(t, notaryDir, homeDir, baseRef, "targets")
 	assert.Assert(t, targetsInRole["latest"] != "targets", "%v", targetsInRole)
 
-	assert.NilError(t, os.RemoveAll(filepath.Join(dir.Join("trust"))))
+	assert.NilError(t, os.RemoveAll(dir.Join("trust")))
 	// Try to pull, should fail because non of these are the release role
 	// FIXME(vdemeester) should be unit test
 	result = icmd.RunCmd(icmd.Command("docker", "pull", targetRef),
@@ -310,7 +309,7 @@ func TestPushWithContentTrustSignsForRolesWithKeysAndValidPaths(t *testing.T) {
 	targetsInRole = notaryListTargetsInRole(t, notaryDir, homeDir, baseRef, "targets")
 	assert.Assert(t, targetsInRole["latest"] != "targets", "%v", targetsInRole)
 
-	assert.NilError(t, os.RemoveAll(filepath.Join(dir.Join("trust"))))
+	assert.NilError(t, os.RemoveAll(dir.Join("trust")))
 	// Try to pull, should fail because non of these are the release role
 	// FIXME(vdemeester) should be unit test
 	result = icmd.RunCmd(icmd.Command("docker", "pull", targetRef),
diff --git a/internal/test/builders/config.go b/internal/test/builders/config.go
@@ -33,9 +33,9 @@ func ConfigName(name string) func(config *swarm.Config) {
 }
 
 // ConfigID sets the config's ID
-func ConfigID(ID string) func(config *swarm.Config) {
+func ConfigID(id string) func(config *swarm.Config) {
 	return func(config *swarm.Config) {
-		config.ID = ID
+		config.ID = id
 	}
 }
 
diff --git a/internal/test/builders/secret.go b/internal/test/builders/secret.go
@@ -42,9 +42,9 @@ func SecretDriver(driver string) func(secret *swarm.Secret) {
 }
 
 // SecretID sets the secret's ID
-func SecretID(ID string) func(secret *swarm.Secret) {
+func SecretID(id string) func(secret *swarm.Secret) {
 	return func(secret *swarm.Secret) {
-		secret.ID = ID
+		secret.ID = id
 	}
 }
 
diff --git a/internal/test/builders/service.go b/internal/test/builders/service.go
@@ -18,9 +18,9 @@ func Service(builders ...func(*swarm.Service)) *swarm.Service {
 }
 
 // ServiceID sets the service ID
-func ServiceID(ID string) func(*swarm.Service) {
+func ServiceID(id string) func(*swarm.Service) {
 	return func(service *swarm.Service) {
-		service.ID = ID
+		service.ID = id
 	}
 }
 
diff --git a/opts/hosts_test.go b/opts/hosts_test.go
@@ -57,7 +57,7 @@ func TestParseDockerDaemonHost(t *testing.T) {
 		"udp://127.0.0.1":               "invalid bind address format: udp://127.0.0.1",
 		"udp://127.0.0.1:2375":          "invalid bind address format: udp://127.0.0.1:2375",
 		"tcp://unix:///run/docker.sock": "invalid proto, expected tcp: unix:///run/docker.sock",
-		" tcp://:7777/path ":            "invalid bind address format:  tcp://:7777/path ",
+		" tcp://:7777/path ":            "invalid bind address format:  tcp://:7777/path ", //nolint:gocritic // ignore mapKey: suspucious whitespace
 		"":                              "invalid bind address format: ",
 	}
 	valids := map[string]string{
diff --git a/opts/opts_test.go b/opts/opts_test.go
@@ -428,10 +428,8 @@ func TestValidateLink(t *testing.T) {
 	for link, expectedError := range invalid {
 		if _, err := ValidateLink(link); err == nil {
 			t.Fatalf("ValidateLink(`%q`) should have failed validation", link)
-		} else {
-			if !strings.Contains(err.Error(), expectedError) {
-				t.Fatalf("ValidateLink(`%q`) error should contain %q", link, expectedError)
-			}
+		} else if !strings.Contains(err.Error(), expectedError) {
+			t.Fatalf("ValidateLink(`%q`) error should contain %q", link, expectedError)
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -206,9 +206,9 @@ func calculateBlockIO(blkio types.BlkioStats) (uint64, uint64) {`
`206`	`206`	`}`
`207`	`207`	`switch bioEntry.Op[0] {`
`208`	`208`	`case 'r', 'R':`
`209`		`- blkRead = blkRead + bioEntry.Value`
	`209`	`+ blkRead += bioEntry.Value`
`210`	`210`	`case 'w', 'W':`
`211`		`- blkWrite = blkWrite + bioEntry.Value`
	`211`	`+ blkWrite += bioEntry.Value`
`212`	`212`	`}`
`213`	`213`	`}`
`214`	`214`	`return blkRead, blkWrite`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ func (c *historyContext) CreatedSince() string {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`func (c *historyContext) CreatedBy() string {`
`100`		`- createdBy := strings.Replace(c.h.CreatedBy, "\t", " ", -1)`
	`100`	`+ createdBy := strings.ReplaceAll(c.h.CreatedBy, "\t", " ")`
`101`	`101`	`if c.trunc {`
`102`	`102`	`return formatter.Ellipsis(createdBy, 45)`
`103`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,8 @@ func (c *pluginContext) Name() string {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`func (c *pluginContext) Description() string {`
`79`		`- desc := strings.Replace(c.p.Config.Description, "\n", "", -1)`
`80`		`- desc = strings.Replace(desc, "\r", "", -1)`
	`79`	`+ desc := strings.ReplaceAll(c.p.Config.Description, "\n", "")`
	`80`	`+ desc = strings.ReplaceAll(desc, "\r", "")`
`81`	`81`	`if c.trunc {`
`82`	`82`	`desc = formatter.Ellipsis(desc, 45)`
`83`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,8 +64,8 @@ func (c *searchContext) Name() string {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`func (c *searchContext) Description() string {`
`67`		`- desc := strings.Replace(c.s.Description, "\n", " ", -1)`
`68`		`- desc = strings.Replace(desc, "\r", " ", -1)`
	`67`	`+ desc := strings.ReplaceAll(c.s.Description, "\n", " ")`
	`68`	`+ desc = strings.ReplaceAll(desc, "\r", " ")`
`69`	`69`	`if c.trunc {`
`70`	`70`	`desc = formatter.Ellipsis(desc, 45)`
`71`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ func TestServiceListServiceStatus(t *testing.T) {`
`161`	`161`	`for _, tc := range tests {`
`162`	`162`	`if quiet {`
`163`	`163`	`tc.withQuiet = quiet`
`164`		`- tc.doc = tc.doc + " with quiet"`
	`164`	`+ tc.doc += " with quiet"`
`165`	`165`	`}`
`166`	`166`	`matrix = append(matrix, tc)`
`167`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -639,11 +639,11 @@ func convertDeployMode(mode string, replicas *uint64) (swarm.ServiceMode, error)`
`639`	`639`	`return serviceMode, nil`
`640`	`640`	`}`
`641`	`641`
`642`		`-func convertDNSConfig(DNS []string, DNSSearch []string) *swarm.DNSConfig {`
`643`		`- if DNS != nil \|\| DNSSearch != nil {`
	`642`	`+func convertDNSConfig(dns []string, dnsSearch []string) *swarm.DNSConfig {`
	`643`	`+ if dns != nil \|\| dnsSearch != nil {`
`644`	`644`	`return &swarm.DNSConfig{`
`645`		`- Nameservers: DNS,`
`646`		`- Search: DNSSearch,`
	`645`	`+ Nameservers: dns,`
	`646`	`+ Search: dnsSearch,`
`647`	`647`	`}`
`648`	`648`	`}`
`649`	`649`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ func (c *mockNativeStore) Get(registryHostname string) (types.AuthConfig, error)`
`182`	`182`	`}`
`183`	`183`
`184`	`184`	`func (c *mockNativeStore) GetAll() (map[string]types.AuthConfig, error) {`
`185`		`- c.GetAllCallCount = c.GetAllCallCount + 1`
	`185`	`+ c.GetAllCallCount++`
`186`	`186`	`return c.authConfigs, nil`
`187`	`187`	`}`
`188`	`188`