Merge pull request #4046 from vvoland/dangling-images-none

thaJeztah · web-flow · commit 881c3535760a · 2023-03-01T00:43:43.000+01:00
formatter: Consider empty RepoTags and RepoDigests as dangling
diff --git a/cli/command/formatter/image.go b/cli/command/formatter/image.go
@@ -27,6 +27,9 @@ type ImageContext struct {
 }
 
 func isDangling(image types.ImageSummary) bool {
+	if len(image.RepoTags) == 0 && len(image.RepoDigests) == 0 {
+		return true
+	}
 	return len(image.RepoTags) == 1 && image.RepoTags[0] == "<none>:<none>" && len(image.RepoDigests) == 1 && image.RepoDigests[0] == "<none>@<none>"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,9 @@ type ImageContext struct {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`func isDangling(image types.ImageSummary) bool {`
	`30`	`+ if len(image.RepoTags) == 0 && len(image.RepoDigests) == 0 {`
	`31`	`+ return true`
	`32`	`+ }`
`30`	`33`	`return len(image.RepoTags) == 1 && image.RepoTags[0] == "<none>:<none>" && len(image.RepoDigests) == 1 && image.RepoDigests[0] == "<none>@<none>"`
`31`	`34`	`}`
`32`	`35`