Skip to content

Commit 5e76d41

Browse files
committed
cli/command: ConfigureAuth: fix links to related tickets
Also adds a TODO to verify if this special handling is still needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 68d791e commit 5e76d41

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

cli/command/registry.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,14 @@ func GetDefaultAuthConfig(cli Cli, checkCredStore bool, serverAddress string, is
8989

9090
// ConfigureAuth handles prompting of user's username and password if needed
9191
func ConfigureAuth(cli Cli, flUser, flPassword string, authconfig *registrytypes.AuthConfig, isDefaultRegistry bool) error {
92-
// On Windows, force the use of the regular OS stdin stream. Fixes #14336/#14210
92+
// On Windows, force the use of the regular OS stdin stream.
93+
//
94+
// See:
95+
// - https://github.com/moby/moby/issues/14336
96+
// - https://github.com/moby/moby/issues/14210
97+
// - https://github.com/moby/moby/pull/17738
98+
//
99+
// TODO(thaJeztah): we need to confirm if this special handling is still needed, as we may not be doing this in other places.
93100
if runtime.GOOS == "windows" {
94101
cli.SetIn(streams.NewIn(os.Stdin))
95102
}

0 commit comments

Comments
 (0)