Skip to content

Commit 557d721

Browse files
committed
completion: remove generic "os-only" for platforms
Using `--platform=linux` or `--platform=windows` is not commonly used (or recommended). Let's remove these from the list of suggested platforms. We should tweak this completion further, and sort the list based on the daemon's platform (putting linux first for a Linux daemon, and windows first on a Windows daemon), possibly with the correct architecture (and os-version) included, but we don't yet provide that information in `/_ping`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 219d3fe commit 557d721

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

cli/command/completion/functions.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ func NoComplete(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCo
152152
}
153153

154154
var commonPlatforms = []string{
155-
"linux",
156155
"linux/386",
157156
"linux/amd64",
158157
"linux/arm",
@@ -169,10 +168,8 @@ var commonPlatforms = []string{
169168
// Not yet supported
170169
"linux/riscv64",
171170

172-
"windows",
173171
"windows/amd64",
174172

175-
"wasip1",
176173
"wasip1/wasm",
177174
}
178175

0 commit comments

Comments
 (0)