Skip to content

Commit 55073c4

Browse files
committed
cli/connhelper/ssh: tweak error-message (capitalize SSH)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 81a5db6 commit 55073c4

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

cli/connhelper/ssh/ssh.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ func ParseURL(daemonURL string) (*Spec, error) {
1717
if errors.As(err, &urlErr) {
1818
err = urlErr.Unwrap()
1919
}
20-
return nil, fmt.Errorf("invalid ssh URL: %w", err)
20+
return nil, fmt.Errorf("invalid SSH URL: %w", err)
2121
}
2222
s, err := newSpec(u)
2323
if err != nil {
24-
return nil, fmt.Errorf("invalid ssh URL: %w", err)
24+
return nil, fmt.Errorf("invalid SSH URL: %w", err)
2525
}
2626
return s, nil
2727
}

cli/connhelper/ssh/ssh_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,41 +87,41 @@ func TestParseURL(t *testing.T) {
8787
{
8888
doc: "malformed URL",
8989
url: "malformed %%url",
90-
expectedError: `invalid ssh URL: invalid URL escape "%%u"`,
90+
expectedError: `invalid SSH URL: invalid URL escape "%%u"`,
9191
},
9292
{
9393
doc: "URL missing scheme",
9494
url: "no-scheme.example.com",
95-
expectedError: "invalid ssh URL: no scheme provided",
95+
expectedError: "invalid SSH URL: no scheme provided",
9696
},
9797
{
9898
doc: "invalid URL with password",
9999
url: "ssh://me:passw0rd@example.com",
100-
expectedError: "invalid ssh URL: plain-text password is not supported",
100+
expectedError: "invalid SSH URL: plain-text password is not supported",
101101
},
102102
{
103103
doc: "invalid URL with query parameter",
104104
url: "ssh://example.com?foo=bar&bar=baz",
105-
expectedError: `invalid ssh URL: query parameters are not allowed: "foo=bar&bar=baz"`,
105+
expectedError: `invalid SSH URL: query parameters are not allowed: "foo=bar&bar=baz"`,
106106
},
107107
{
108108
doc: "invalid URL with fragment",
109109
url: "ssh://example.com#bar",
110-
expectedError: `invalid ssh URL: fragments are not allowed: "bar"`,
110+
expectedError: `invalid SSH URL: fragments are not allowed: "bar"`,
111111
},
112112
{
113113
doc: "invalid URL without hostname",
114114
url: "ssh://",
115-
expectedError: "invalid ssh URL: hostname is empty",
115+
expectedError: "invalid SSH URL: hostname is empty",
116116
},
117117
{
118118
url: "ssh:///no-hostname",
119-
expectedError: "invalid ssh URL: hostname is empty",
119+
expectedError: "invalid SSH URL: hostname is empty",
120120
},
121121
{
122122
doc: "invalid URL with unsupported scheme",
123123
url: "https://example.com",
124-
expectedError: `invalid ssh URL: incorrect scheme: https`,
124+
expectedError: `invalid SSH URL: incorrect scheme: https`,
125125
},
126126
}
127127
for _, tc := range testCases {

0 commit comments

Comments
 (0)