Skip to content

Commit 21e96ea

Browse files
committed
cli/command/completion: use ContainerState consts in tests
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent c9d04c7 commit 21e96ea

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

cli/command/completion/functions_test.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ func TestCompleteContainerNames(t *testing.T) {
8282
doc: "all containers",
8383
showAll: true,
8484
containers: []container.Summary{
85-
{ID: "id-c", State: "running", Names: []string{"/container-c", "/container-c/link-b"}},
86-
{ID: "id-b", State: "created", Names: []string{"/container-b"}},
87-
{ID: "id-a", State: "exited", Names: []string{"/container-a"}},
85+
{ID: "id-c", State: container.StateRunning, Names: []string{"/container-c", "/container-c/link-b"}},
86+
{ID: "id-b", State: container.StateCreated, Names: []string{"/container-b"}},
87+
{ID: "id-a", State: container.StateExited, Names: []string{"/container-a"}},
8888
},
8989
expOut: []string{"container-c", "container-c/link-b", "container-b", "container-a"},
9090
expOpts: container.ListOptions{All: true},
@@ -95,9 +95,9 @@ func TestCompleteContainerNames(t *testing.T) {
9595
showAll: true,
9696
showIDs: true,
9797
containers: []container.Summary{
98-
{ID: "id-c", State: "running", Names: []string{"/container-c", "/container-c/link-b"}},
99-
{ID: "id-b", State: "created", Names: []string{"/container-b"}},
100-
{ID: "id-a", State: "exited", Names: []string{"/container-a"}},
98+
{ID: "id-c", State: container.StateRunning, Names: []string{"/container-c", "/container-c/link-b"}},
99+
{ID: "id-b", State: container.StateCreated, Names: []string{"/container-b"}},
100+
{ID: "id-a", State: container.StateExited, Names: []string{"/container-a"}},
101101
},
102102
expOut: []string{"id-c", "container-c", "container-c/link-b", "id-b", "container-b", "id-a", "container-a"},
103103
expOpts: container.ListOptions{All: true},
@@ -107,7 +107,7 @@ func TestCompleteContainerNames(t *testing.T) {
107107
doc: "only running containers",
108108
showAll: false,
109109
containers: []container.Summary{
110-
{ID: "id-c", State: "running", Names: []string{"/container-c", "/container-c/link-b"}},
110+
{ID: "id-c", State: container.StateRunning, Names: []string{"/container-c", "/container-c/link-b"}},
111111
},
112112
expOut: []string{"container-c", "container-c/link-b"},
113113
expDirective: cobra.ShellCompDirectiveNoFileComp,
@@ -116,12 +116,12 @@ func TestCompleteContainerNames(t *testing.T) {
116116
doc: "with filter",
117117
showAll: true,
118118
filters: []func(container.Summary) bool{
119-
func(container container.Summary) bool { return container.State == "created" },
119+
func(ctr container.Summary) bool { return ctr.State == container.StateCreated },
120120
},
121121
containers: []container.Summary{
122-
{ID: "id-c", State: "running", Names: []string{"/container-c", "/container-c/link-b"}},
123-
{ID: "id-b", State: "created", Names: []string{"/container-b"}},
124-
{ID: "id-a", State: "exited", Names: []string{"/container-a"}},
122+
{ID: "id-c", State: container.StateRunning, Names: []string{"/container-c", "/container-c/link-b"}},
123+
{ID: "id-b", State: container.StateCreated, Names: []string{"/container-b"}},
124+
{ID: "id-a", State: container.StateExited, Names: []string{"/container-a"}},
125125
},
126126
expOut: []string{"container-b"},
127127
expOpts: container.ListOptions{All: true},
@@ -131,13 +131,13 @@ func TestCompleteContainerNames(t *testing.T) {
131131
doc: "multiple filters",
132132
showAll: true,
133133
filters: []func(container.Summary) bool{
134-
func(container container.Summary) bool { return container.ID == "id-a" },
135-
func(container container.Summary) bool { return container.State == "created" },
134+
func(ctr container.Summary) bool { return ctr.ID == "id-a" },
135+
func(ctr container.Summary) bool { return ctr.State == container.StateCreated },
136136
},
137137
containers: []container.Summary{
138-
{ID: "id-c", State: "running", Names: []string{"/container-c", "/container-c/link-b"}},
139-
{ID: "id-b", State: "created", Names: []string{"/container-b"}},
140-
{ID: "id-a", State: "created", Names: []string{"/container-a"}},
138+
{ID: "id-c", State: container.StateRunning, Names: []string{"/container-c", "/container-c/link-b"}},
139+
{ID: "id-b", State: container.StateCreated, Names: []string{"/container-b"}},
140+
{ID: "id-a", State: container.StateCreated, Names: []string{"/container-a"}},
141141
},
142142
expOut: []string{"container-a"},
143143
expOpts: container.ListOptions{All: true},

0 commit comments

Comments
 (0)