Skip to content

Commit 0f59f04

Browse files
committed
Update minimum Go version to 1.19
On Go 1.18 since a5ebe22, we get: # github.com/docker/docker-credential-helpers/client vendor/github.com/docker/docker-credential-helpers/client/command.go:34:39: programCmd.Environ undefined (type *exec.Cmd has no field or method Environ) note: module requires Go 1.19 # github.com/docker/cli/cli/connhelper/commandconn cli/connhelper/commandconn/commandconn.go:71:22: undefined: atomic.Bool cli/connhelper/commandconn/commandconn.go:76:22: undefined: atomic.Bool cli/connhelper/commandconn/commandconn.go:77:22: undefined: atomic.Bool cli/connhelper/commandconn/commandconn.go:78:22: undefined: atomic.Bool These go away when building against 1.19+. Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
1 parent 162e490 commit 0f59f04

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

scripts/vendor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ init() {
1818
cat > go.mod <<EOL
1919
module github.com/docker/cli
2020
21-
go 1.18
21+
go 1.19
2222
EOL
2323
}
2424

2525
update() {
26-
(set -x ; go mod tidy -compat=1.18 -modfile=vendor.mod; go mod vendor -modfile=vendor.mod)
26+
(set -x ; go mod tidy -compat=1.19 -modfile=vendor.mod; go mod vendor -modfile=vendor.mod)
2727
}
2828

2929
validate() {

vendor.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module github.com/docker/cli
44
// There is no 'go.mod' file, as that would imply opting in for all the rules
55
// around SemVer, which this repo cannot abide by as it uses CalVer.
66

7-
go 1.18
7+
go 1.19
88

99
require (
1010
dario.cat/mergo v1.0.0

0 commit comments

Comments
 (0)