Skip to content

Commit 08f8650

Browse files
committed
cli/command: remove deprecated ManifestStore from CLI interface
This method is a shallow wrapper around manifeststore.NewStore, but due to its signature resulted in various dependencies becoming a dependency of the "command" package. Consequence of this was that cli-plugins, which need the cli/command package, would also get those dependencies. It is no longer used, and was deprecated in e32d5d5. This patch removes the ManifestStore method from the interface Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 66eb27a commit 08f8650

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

cli/command/cli_deprecated.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,34 +2,19 @@ package command
22

33
import (
44
"context"
5-
"path/filepath"
65

7-
"github.com/docker/cli/cli/config"
8-
manifeststore "github.com/docker/cli/cli/manifest/store"
96
registryclient "github.com/docker/cli/cli/registry/client"
107
"github.com/docker/docker/api/types/registry"
118
)
129

1310
type DeprecatedManifestClient interface {
14-
// ManifestStore returns a store for local manifests
15-
//
16-
// Deprecated: use [manifeststore.NewStore] instead. This method is no longer used and will be removed in the next release.
17-
ManifestStore() manifeststore.Store
18-
1911
// RegistryClient returns a client for communicating with a Docker distribution
2012
// registry.
2113
//
2214
// Deprecated: use [registryclient.NewRegistryClient]. This method is no longer used and will be removed in the next release.
2315
RegistryClient(bool) registryclient.RegistryClient
2416
}
2517

26-
// ManifestStore returns a store for local manifests
27-
//
28-
// Deprecated: use [manifeststore.NewStore] instead. This method is no longer used and will be removed in the next release.
29-
func (*DockerCli) ManifestStore() manifeststore.Store {
30-
return manifeststore.NewStore(filepath.Join(config.Dir(), "manifests"))
31-
}
32-
3318
// RegistryClient returns a client for communicating with a Docker distribution
3419
// registry
3520
//

0 commit comments

Comments
 (0)