Fixed various PHP 5.3 syntax issues

Author: dmhendricks

README.md

@@ -6,6 +6,11 @@ This is a boilerplate WordPress plugin featuring namespace autoloading and integ
 
 It may also be used as the means of [separating custom code](http://www.billerickson.net/core-functionality-plugin/) from the theme.
 
+## Requirements
+
+* WordPress 4.0 or higher
+* PHP 5.4.0 or higher
+
 ## Installation
 
 ### Clone Repository
@@ -32,6 +37,8 @@ It may also be used as the means of [separating custom code](http://www.billeric
 * Possibly add TGMPA example
 * Allow loading Carbon Fields via [plugin](https://github.com/dmhendricks/carbon-fields-loader) rather than Composer dependency
 * Test compatibility with WordPress 4.0 and higher
+* Remove closing ?> tags per [recommendation](https://github.com/dmhendricks/wordpress-base-plugin/issues/1)
+* Add uninstall.php
 
 ## Change Log
 
@@ -40,8 +47,9 @@ It may also be used as the means of [separating custom code](http://www.billeric
 * Added Object Cache class
 * Added example of loading Font Awesome if enabled in plugin settings
 * Removed `./vendor` from repo
-* Renamed Helpers Class to Utils
-* Tested PHP 5.3 - 7.1 compatibility
+* Renamed Helpers class to Utils
+* Tested PHP 5.4 - 7.1 compatibility
+* Fixed various PHP 5.3 issues; bumped minimum suggested version to 5.4.0
 * Added minimum PHP version check
 * Added screenshot
 

app/CPT.php

@@ -20,7 +20,7 @@ function __construct() {
   private function add_post_type_client() {
     // Reference: https://github.com/jjgrainger/PostTypes
 
-    $options = [
+    $options = array(
       'supports' => array('title'),
       'labels' => array(
         'menu_name' => 'Client List'
@@ -31,7 +31,7 @@ private function add_post_type_client() {
       'show_in_nav_menus' => false,
       'rewrite' => false,
       'has_archive' => false
-    ];
+    );
 
     $cpt = new \PostTypes\PostType(
       array(
@@ -65,7 +65,7 @@ private function add_post_type_client() {
 
   public function hide_publishing_actions() {
     global $post;
-    if( in_array($post->post_type, ['client']) ) {
+    if( in_array($post->post_type, array('client')) ) {
       echo '<style type="text/css">
         #misc-publishing-actions,
         #minor-publishing-actions{

app/Cache.php

@@ -47,12 +47,12 @@ public static function get_object( $key = null, $callback ) {
     */
   public static function flush($ID = null, $post = null) {
 
-    $result = ['success' => true];
+    $result = array('success' => true);
 
     try {
       wp_cache_flush();
     } catch (Exception $e) {
-      $result = ['success' => false, 'message' => $e->getMessage()];
+      $result = array('success' => false, 'message' => $e->getMessage());
     }
 
     if( defined('DOING_AJAX') && DOING_AJAX ) {

app/Plugin.php

@@ -56,15 +56,15 @@ private function verify_dependencies() {
 
     $error = null;
 
-    if( version_compare( phpversion(), self::$settings['deps']['php'], '<' ) ) {
+    if( $this->is_php_version( self::$settings['deps']['php'], '<' ) ) {
       $error = '<strong>' . self::$settings['data']['Name'] . ':</strong> ' . __('This plugin is not supported on versions of PHP under' . ' ' . self::$settings['deps']['php'] . '.' );
     } else if(!defined('\\Carbon_Fields\\VERSION')) {
       $error = '<strong>' . self::$settings['data']['Name'] . ':</strong> ' . __('A fatal error occurred while trying to load dependencies.');
     } else if( version_compare( \Carbon_Fields\VERSION, self::$settings['deps']['carbon_fields'], '<' ) ) {
       $error = '<strong>' . self::$settings['data']['Name'] . ':</strong> ' . __('Unable to load. An outdated version of Carbon Fields has been loaded:' . ' ' . \Carbon_Fields\VERSION) . ' (&gt;= '.self::$settings['deps']['carbon_fields'] . ' ' . __('required') . ')';
     }
 
-    if($error) Helpers::show_notice($error, 'error', false);
+    if($error) Utils::show_notice($error, 'error', false);
     return !$error;
 
   }
@@ -78,12 +78,13 @@ public function get_plugin_option( $key, $cache = true, $source = null ) {
 
     if( $cache ) {
       // Attempt to get value from cache, else return value from database
-      return Cache::get_object( self::$prefix . $key, function() use (&$key, &$source) {
-        return carbon_get_theme_option( self::$prefix.$key );
+      $prefix = self::$prefix; // For PHP 5.3 compatibility
+      return Cache::get_object( self::$prefix . $key, function() use (&$key, &$source, &$prefix) {
+        return carbon_get_theme_option( $prefix.$key );
       });
     } else {
       // Return uncached value
-      return carbon_get_theme_option( self::$prefix.$key );
+      return carbon_get_theme_option( $prefix.$key );
     }
 
   }
@@ -96,7 +97,7 @@ public function get_plugin_option( $key, $cache = true, $source = null ) {
     * @return bool
     */
   public function is_production() {
-    return ( !defined('WP_ENV') || (defined('WP_ENV') && !in_array(WP_ENV, ['development', 'staging']) ) );
+    return ( !defined( 'WP_ENV' ) || ( defined('WP_ENV' ) && !in_array( WP_ENV, array('development', 'staging') ) ) );
   }
 
   /**
@@ -108,6 +109,15 @@ public function is_ajax() {
     return defined('DOING_AJAX') && DOING_AJAX;
   }
 
+/**
+  * Wrapper for phpversion() and version_compare()
+  *
+  * @return bool
+  */
+  public function is_php_version( $version = '5.3', $operator = '>=' ) {
+    return version_compare( phpversion(), $version, $operator );
+  }
+
   /**
     * Returns script ?ver= version based on environment (WP_ENV)
     *

wordpress-base-plugin.php

@@ -42,7 +42,7 @@
 	'textdomain' => 'my-plugin',
 	'object_cache_group' => 'my_plugin_cache',
 	'object_cache_expire' => 72, // In hours
-	'deps' => ['php' => '5.3.29', 'carbon_fields' => '2.0.0'], // Optional
+	'deps' => array('php' => '5.4.0', 'carbon_fields' => '2.0.0'), // Optional
 	'prefix' => 'myplugin_' // Change to your own unique field prefix
 ));
 ?>