Skip to content

Commit f0e0cd2

Browse files
authored
Prefix github issue macros with project name
This is because each project has a different url path to link to their issues.
1 parent 773b50e commit f0e0cd2

1 file changed

Lines changed: 15 additions & 5 deletions

File tree

changed.d

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,7 @@ GithubIssue[][string /*type*/ ][string /*comp*/] getGithubIssuesRest(string revR
312312
import std.algorithm.searching : canFind;
313313

314314
GithubIssue[][string][string] ret;
315+
// Keep this list of comps in sync with the switch statement in writeBugzillaChanges
315316
string[2][] comps =
316317
[ [ "dlang.org", "dlang.org"]
317318
, [ "dmd", "DMD Compiler"]
@@ -686,12 +687,21 @@ void writeBugzillaChanges(Entries, Writer)(BugzillaOrGithub bog, Entries entries
686687
case BugzillaOrGithub.github: return "BUGSTITLE_GITHUB";
687688
}
688689
}();
689-
const string macroLi = () {
690+
const macroLi = (string component) {
690691
final switch(bog) {
691-
case BugzillaOrGithub.bugzilla: return "BUGZILLA";
692-
case BugzillaOrGithub.github: return "GITHUB";
692+
case BugzillaOrGithub.bugzilla:
693+
return "BUGZILLA";
694+
case BugzillaOrGithub.github:
695+
final switch (component)
696+
{
697+
case "dlang.org": return "DLANGORGGITHUB";
698+
case "DMD Compiler": return "DMDGITHUB";
699+
case "Phobos": return "PHOBOSGITHUB";
700+
case "Tools": return "TOOLSGITHUB";
701+
case "Installer": return "INSTALLERGITHUB";
702+
}
693703
}
694-
}();
704+
};
695705

696706
foreach (component; components)
697707
{
@@ -705,7 +715,7 @@ void writeBugzillaChanges(Entries, Writer)(BugzillaOrGithub bog, Entries entries
705715
alias lessFunc = less!(ElementEncodingType!(typeof(*bugs)));
706716
foreach (bug; sort!lessFunc(*bugs))
707717
{
708-
w.formattedWrite("$(LI $(%s %s): %s)\n", macroLi,
718+
w.formattedWrite("$(LI $(%s %s): %s)\n", macroLi(component),
709719
bug.id, bug.summary.escapeParens());
710720
}
711721
w.put(")\n");

0 commit comments

Comments
 (0)