Modernize Python module's build flow

Author: airween

bindings/Makefile.am

@@ -6,14 +6,19 @@ all-py: pybinding.c
 	--build-base $(shell readlink -f $(builddir))/build \
 	--verbose)
 
-install-exec-py:
-	$(PYTHON) $(srcdir)/setup.py install \
-	--prefix $(DESTDIR)$(prefix) \
-	--verbose
+PYTHON_INSTALL_CMD = pip install --root=$(DESTDIR)/ \
+                --no-deps \
+                --ignore-installed \
+                --no-build-isolation .
+
+PYTHON_UNINSTALL_CMD = rm -rf $(DESTDIR)$(libdir)/python*/dist-packages/mypylogparser*
+
 
 clean-py:
 	rm -rf *.o *.so *.la build
 
+else
+PYTHON_INSTALL_CMD = @echo "Python support disabled, skipping..."
 endif
 
 
@@ -76,6 +81,7 @@ all-local:
 
 install-exec-local:
 	$(MAKE) $(BINDING_INSTALL_EXEC)
+	$(PYTHON_INSTALL_CMD)
 
 clean-local:
 	$(MAKE) $(BINDING_CLEAN)

bindings/Makefile.in

@@ -289,6 +289,13 @@ target_alias = @target_alias@
 top_build_prefix = @top_build_prefix@
 top_builddir = @top_builddir@
 top_srcdir = @top_srcdir@
+@ENABLE_PYTHON_FALSE@PYTHON_INSTALL_CMD = @echo "Python support disabled, skipping..."
+@ENABLE_PYTHON_TRUE@PYTHON_INSTALL_CMD = pip install --root=$(DESTDIR)/ \
+@ENABLE_PYTHON_TRUE@                --no-deps \
+@ENABLE_PYTHON_TRUE@                --ignore-installed \
+@ENABLE_PYTHON_TRUE@                --no-build-isolation .
+
+@ENABLE_PYTHON_TRUE@PYTHON_UNINSTALL_CMD = rm -rf $(DESTDIR)$(libdir)/python*/dist-packages/mypylogparser*
 @ENABLE_LUA_TRUE@LUALIBFLAG = -shared -fpic
 @ENABLE_LUA_TRUE@LUACFLAGS = -I../src $(LUA_INCLUDE) -L../src/.libs 
 @ENABLE_RUBY_TRUE@RUBYLIBFLAG = -shared -fPIC -L$(RUBY_ARCHLIBDIR)
@@ -494,11 +501,6 @@ uninstall-am:
 @ENABLE_PYTHON_TRUE@	--build-base $(shell readlink -f $(builddir))/build \
 @ENABLE_PYTHON_TRUE@	--verbose)
 
-@ENABLE_PYTHON_TRUE@install-exec-py:
-@ENABLE_PYTHON_TRUE@	$(PYTHON) $(srcdir)/setup.py install \
-@ENABLE_PYTHON_TRUE@	--prefix $(DESTDIR)$(prefix) \
-@ENABLE_PYTHON_TRUE@	--verbose
-
 @ENABLE_PYTHON_TRUE@clean-py:
 @ENABLE_PYTHON_TRUE@	rm -rf *.o *.so *.la build
 
@@ -542,6 +544,7 @@ all-local:
 
 install-exec-local:
 	$(MAKE) $(BINDING_INSTALL_EXEC)
+	$(PYTHON_INSTALL_CMD)
 
 clean-local:
 	$(MAKE) $(BINDING_CLEAN)

bindings/pyproject.toml

@@ -0,0 +1,14 @@
+[build-system]
+requires = ["setuptools>=61.0", "wheel"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "mscpylogparser"
+version = "0.3.0"
+description = "Python bindings for libmsclogparser"
+readme = "README.md"
+authors = [{name = "Ervin Hegedüs", email = "airween@digitalwave.hu"}]
+dependencies = []
+
+[tool.setuptools]
+py-modules = []

bindings/setup.py

@@ -1,20 +1,15 @@
-from distutils.core import setup, Extension
+from setuptools import setup, Extension
+import os
 
-def main():
-    setup(name="mscpylogparser",
-          version="0.2.0",
-          description="Python interface for parsing ModSecurity generated error.log lines",
-          author="Ervin Hegedus",
-          author_email="airween@digitalwave.hu",
-          ext_modules=[
-            Extension("mscpylogparser",
-                sources = ["pybinding.c"],
-                library_dirs = ["../src/.libs",],
-                libraries = ['msclogparser'],
-                extra_compile_args = ["-Wall", "-I../src"],
-            )
-          ],
-        )
+module = Extension(
+    'mscpylogparser',
+    sources=['pybinding.c'],
+    libraries=['msclogparser'],
+    include_dirs=['../src', '/usr/include', '/usr/local/include'],
+    library_dirs=['../src/.libs', '/usr/lib', '/usr/local/lib'],
+)
+
+setup(
+    ext_modules=[module],
+)
 
-if __name__ == "__main__":
-    main()

configure

@@ -2921,7 +2921,7 @@ ac_config_headers="$ac_config_headers config.h"
 
 
 
-VER_NUMBER=0:2:0
+VER_NUMBER=0:3:0
 
 
 ac_ext=c
@@ -14820,7 +14820,6 @@ printf "%s\n" "#define HAVE_PYTHON 1" >>confdefs.h
 
 fi
         BINDING_ALL="${BINDING_ALL} all-py"
-        BINDING_INSTALL_EXEC="${BINDING_INSTALL_EXEC} install-exec-py"
         BINDING_CLEAN="${BINDING_CLEAN} clean-py"
 
 else case e in #(

configure.ac

@@ -104,7 +104,6 @@ AS_IF([test "x$wantpythonbinding" = xtrue],
             ]
         )
         BINDING_ALL="${BINDING_ALL} all-py"
-        BINDING_INSTALL_EXEC="${BINDING_INSTALL_EXEC} install-exec-py"
         BINDING_CLEAN="${BINDING_CLEAN} clean-py"
 	],
     [AC_MSG_RESULT([no])]