Skip to content

Commit 41eccdb

Browse files
committed
Merge PR QuantStack#15: Add null-check for getContainer() combined with remove() approach
2 parents 0f8a7db + b0ce5e4 commit 41eccdb

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

src/index.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ L.Control.SplitMap = L.Control.extend({
9595
}
9696
this._leftLayers.forEach((left_layer)=> {
9797
if (left_layer.getContainer) {
98-
left_layer.getContainer().remove()
98+
const container = left_layer.getContainer()
99+
if (container) {
100+
container.remove()
101+
}
99102
}
100103
else {
101104
left_layer.getPane().remove()
@@ -104,7 +107,10 @@ L.Control.SplitMap = L.Control.extend({
104107

105108
this._rightLayers.forEach((right_layer)=>{
106109
if (right_layer.getContainer) {
107-
right_layer.getContainer().remove()
110+
const container = right_layer.getContainer()
111+
if (container) {
112+
container.remove()
113+
}
108114
}
109115
else {
110116
right_layer.getPane().remove()
@@ -113,9 +119,6 @@ L.Control.SplitMap = L.Control.extend({
113119
this._removeEvents()
114120
L.DomUtil.remove(this._container)
115121
this._map = null
116-
117-
// print the layers
118-
119122
return this
120123
},
121124

0 commit comments

Comments
 (0)