Add impl on positionsClaim.ts

[aggre]

What would you like to share?

Add impl on:

dev-kit-js/lib/agent/positionsClaim.ts

Lines 1 to 11 in 872b06e

	import { TransactionResponse } from '@ethersproject/abstract-provider'
	import { FallbackableOverrides } from '../common/utils/execute'
	import { Provider } from '@ethersproject/abstract-provider'
	import { UndefinedOr } from '@devprotocol/util-ts'
	type PositionsClaim = (options: {
	readonly provider: Provider
	readonly positionId: number
	readonly withdrawalAmount: string
	readonly overrides?: FallbackableOverrides
	}) => Promise<UndefinedOr<TransactionResponse>>

Additional information

• This function calls lib/ethereum/lockup/withdrawByPosition.ts on L1.
• This function calls lib/l2/lockup on L2.
• The implementation of these lines should be helpful.

Code of Conduct

• I agree to follow this project's Code of Conduct

[aggre]

Add impl on positionsClaim.ts

[Omcodes23]

🤖 Crawly Smart Analysis

Likely Root Cause: The issue is likely related to the implementation not being fully completed or correctly handling the logic for both L1 and L2 environments.

Concise Step-by-Step Fix Plan:

1. Understand Existing Code:

   • Review the existing implementations in positionsCreate.ts (L2) and withdrawByPosition.ts (L1).

2. Identify Differences:

   • Compare the logic between positionsCreate.ts and withdrawByPosition.ts to identify any discrepancies or missing steps.

3. Implement Missing Logic:

   • Add the necessary implementation in positionsClaim.ts for both L1 and L2 environments.
   • Ensure that the logic is consistent with the existing implementations.

4. Test Thoroughly:

   • Write unit tests to cover all possible scenarios for both L1 and L2.
   • Run integration tests to ensure that the new implementation works correctly in both environments.

5. Review and Refine:

   • Review the code by peers or maintainers to catch any potential issues.
   • Make necessary refinements based on feedback.

Confidence Score: 0.9

Suggested Target File Path:
file_path: lib/agent/positionsClaim.ts

Memory key: dev-protocol/dev-kit-js#791:2022-04-22T03:05:05+00:00