don't call splice() when indexOf() returns -1

TooTallNate · TooTallNate · commit 25e07c78fc5e · 2017-08-08T14:42:25.000-07:00
diff --git a/src/debug.js b/src/debug.js
@@ -132,8 +132,13 @@ function createDebug(namespace) {
 }
 
 function destroy () {
-  const index = exports.instances.indexOf(this)
-  exports.instances.splice(index, 1)
+  var index = exports.instances.indexOf(this);
+  if (index !== -1) {
+    exports.instances.splice(index, 1);
+    return true;
+  } else {
+    return false;
+  }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -132,8 +132,13 @@ function createDebug(namespace) {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`function destroy () {`
`135`		`- const index = exports.instances.indexOf(this)`
`136`		`- exports.instances.splice(index, 1)`
	`135`	`+ var index = exports.instances.indexOf(this);`
	`136`	`+ if (index !== -1) {`
	`137`	`+ exports.instances.splice(index, 1);`
	`138`	`+ return true;`
	`139`	`+ } else {`
	`140`	`+ return false;`
	`141`	`+ }`
`137`	`142`	`}`
`138`	`143`
`139`	`144`	`/**`