proper whatif support

Author: nvarscar

internal/functions/Initialize-ExternalLibrary.ps1

@@ -1,5 +1,7 @@
 function Initialize-ExternalLibrary {
     #Load external libraries for a specific RDBMS
+    [CmdletBinding(SupportsShouldProcess)]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSShouldProcess", '')]
     Param (
         [Parameter(Mandatory)]
         [DBOps.ConnectionType]$Type
@@ -39,7 +41,7 @@ function Initialize-ExternalLibrary {
     if (-Not (Test-DBOSupportedSystem -Type $Type)) {
         Write-PSFMessage -Level Warning -Message "Installing dependent libraries for $Type connections"
         # Install dependencies into the current user scope
-        $null = Install-DBOSupportLibrary -Type $Type -Scope CurrentUser
+        $null = Install-DBOSupportLibrary -Type $Type -Scope CurrentUser -WhatIf:$WhatIfPreference
         # test again
         if (-Not (Test-DBOSupportedSystem -Type $Type)) {
             Write-PSFMessage -Level Warning -Message "Dependent libraries for $Type were not found. Run Install-DBOSupportLibrary -Type $Type"

internal/functions/Install-NugetPackage.ps1

@@ -93,7 +93,7 @@ function Install-NugetPackage {
         }
         $folder = New-Item -ItemType Directory -Path $path -Force
 
-        $baseAddressUrl = $indexObject.resources | Where-Object { $_.'@type' -eq 'PackageBaseAddress/3.0.0' } | Select-Object -First 1
+        $baseAddressUrl = $index.resources | Where-Object { $_.'@type' -eq 'PackageBaseAddress/3.0.0' } | Select-Object -First 1
         $downloadUrl = "$($baseAddressUrl.'@id')$packageLowerName/$selectedVersion/$fileName"
         Invoke-WebRequest -Uri $downloadUrl -OutFile $packagePath -ErrorAction Stop
         Write-PSFMessage -Level Verbose -Message "Extracting $fileName to $folder"