Invoke-DbaQuery - Add -QuotedIdentifier parameter for filtered index compatibility (#10066)

Author: potatoqualitee

private/functions/Invoke-DbaAsync.ps1

@@ -37,6 +37,10 @@ function Invoke-DbaAsync {
         .PARAMETER NoExec
             Use this switch to prepend SET NOEXEC ON and append SET NOEXEC OFF to each statement
 
+        .PARAMETER QuotedIdentifier
+            Use this switch to prepend SET QUOTED_IDENTIFIER ON to each statement.
+            Required for INSERT/UPDATE/DELETE on tables with filtered indexes, indexed views, computed columns, or XML indexes.
+
         .PARAMETER EnableException
         By default, when something goes wrong we try to catch it, interpret it and give you a friendly warning message.
 
@@ -74,6 +78,9 @@ function Invoke-DbaAsync {
         [switch]
         $NoExec,
 
+        [switch]
+        $QuotedIdentifier,
+
         [switch]$EnableException
     )
 
@@ -184,8 +191,11 @@ function Invoke-DbaAsync {
         $Pieces = $Pieces | Where-Object { $_.Trim().Length -gt 0 }
         foreach ($piece in $Pieces) {
             $runningStatement = $piece
+            if ($QuotedIdentifier) {
+                $runningStatement = "SET QUOTED_IDENTIFIER ON; " + $runningStatement
+            }
             if ($NoExec) {
-                $runningStatement = "SET NOEXEC ON; " + $piece + " ;SET NOEXEC OFF;"
+                $runningStatement = "SET NOEXEC ON; " + $runningStatement + " ;SET NOEXEC OFF;"
             }
             $cmd = New-Object Microsoft.Data.SqlClient.SqlCommand
             $cmd.CommandText = $runningStatement

public/Invoke-DbaQuery.ps1

@@ -80,6 +80,10 @@ function Invoke-DbaQuery {
         Enables syntax and semantic validation without executing the actual statements. The SQL engine parses and compiles queries but doesn't run them.
         Use this to validate T-SQL syntax, check object references, and verify permissions before running potentially destructive scripts in production environments.
 
+    .PARAMETER QuotedIdentifier
+        Prepends SET QUOTED_IDENTIFIER ON to each batch before execution. This is required for INSERT, UPDATE, and DELETE operations on tables with filtered indexes, indexed views, computed columns, or XML indexes.
+        Use this when modifying tables with filtered indexes and experiencing silent failures, as SMO connections may have QUOTED_IDENTIFIER set to OFF depending on server/database configuration.
+
     .PARAMETER AppendConnectionString
         Adds custom connection string parameters for specialized connection requirements like MultiSubnetFailover, encryption settings, or timeout values.
         Use this for Availability Group connections, Always Encrypted scenarios, or when you need connection properties not available through standard parameters. Authentication must still be handled via SqlInstance and SqlCredential.
@@ -184,6 +188,11 @@ function Invoke-DbaQuery {
 
         Leverages your own parameters, giving you full power, mimicking Connect-DbaInstance's `-MultiSubnetFailover -ConnectTimeout 60`, to adhere to official guidelines to target FCI or AG listeners.
         See https://learn.microsoft.com/en-us/dotnet/framework/data/adonet/sql/sqlclient-support-for-high-availability-disaster-recovery#connecting-with-multisubnetfailover
+
+    .EXAMPLE
+        PS C:\> Invoke-DbaQuery -SqlInstance server1 -Database tempdb -Query "INSERT INTO dbo.TableWithFilteredIndex (Id, Name) VALUES (1, 'Test')" -QuotedIdentifier
+
+        Executes an INSERT statement with QUOTED_IDENTIFIER set to ON. This is required when modifying tables that have filtered indexes, as SQL Server requires this setting for such operations.
     #>
     [CmdletBinding(DefaultParameterSetName = "Query")]
     param (
@@ -213,6 +222,7 @@ function Invoke-DbaQuery {
         [Microsoft.SqlServer.Management.Smo.Database[]]$InputObject,
         [switch]$ReadOnly,
         [switch]$NoExec,
+        [switch]$QuotedIdentifier,
         [string]$AppendConnectionString,
         [switch]$EnableException
     )
@@ -254,6 +264,9 @@ function Invoke-DbaQuery {
         if (Test-Bound -ParameterName "NoExec") {
             $splatInvokeDbaSqlAsync["NoExec"] = $NoExec
         }
+        if (Test-Bound -ParameterName "QuotedIdentifier") {
+            $splatInvokeDbaSqlAsync["QuotedIdentifier"] = $QuotedIdentifier
+        }
 
         if (Test-Bound -ParameterName "File") {
             $files = @()

tests/Invoke-DbaQuery.Tests.ps1

@@ -27,6 +27,7 @@ Describe $CommandName -Tag UnitTests {
                 "EnableException",
                 "CommandType",
                 "NoExec",
+                "QuotedIdentifier",
                 "AppendConnectionString"
             )
             Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $hasParameters | Should -BeNullOrEmpty
@@ -358,6 +359,30 @@ SELECT 2
         { Invoke-DbaQuery -SqlInstance $TestConfig.instance2 -Database tempdb -Query "SELEC p FROM c" -NoExec -EnableException } | Should -Throw "Incorrect syntax near 'SELEC'."
     }
 
+    It "supports QuotedIdentifier for filtered index compatibility" {
+        # Create table with filtered index that requires QUOTED_IDENTIFIER ON
+        $tableName = "dbatoolsci_TestFiltered_$(Get-Random)"
+        $setupQuery = @"
+IF OBJECT_ID('tempdb.dbo.$tableName') IS NOT NULL DROP TABLE dbo.$tableName;
+CREATE TABLE dbo.$tableName (Id INT PRIMARY KEY, Name VARCHAR(100), IsDeleted BIT DEFAULT 0);
+CREATE INDEX IX_Filtered ON dbo.$tableName(Name) WHERE IsDeleted = 0;
+"@
+        $null = Invoke-DbaQuery -SqlInstance $TestConfig.instance2 -Database tempdb -Query $setupQuery
+
+        # Insert with QuotedIdentifier should succeed
+        $splatInsert = @{
+            SqlInstance      = $TestConfig.instance2
+            Database         = "tempdb"
+            Query            = "INSERT INTO dbo.$tableName (Id, Name) VALUES (1, 'Test'); SELECT COUNT(*) as cnt FROM dbo.$tableName;"
+            QuotedIdentifier = $true
+        }
+        $result = Invoke-DbaQuery @splatInsert
+        $result.cnt | Should -Be 1
+
+        # Cleanup
+        $null = Invoke-DbaQuery -SqlInstance $TestConfig.instance2 -Database tempdb -Query "DROP TABLE dbo.$tableName"
+    }
+
     It "supports dropping temp objects (#8472)" {
         $sql = "CREATE PROC #DropStatistics
                 AS

tests/pester.groups.ps1

@@ -24,7 +24,8 @@ $TestsRunGroups = @{
     "appveyor_disabled" = @(
         'Backup-DbaDbCertificate',
         'Test-DbaDbLogShipStatus',
-        'Invoke-DbaDbMirroring'
+        'Invoke-DbaDbMirroring',
+        'New-DbaEndpoint'
     )
     # do not run everywhere
     "disabled"          = @()