Use Invoke-DbaQuery instead of ExecuteNonQuery for long batches to avoid issues on AppVeyor (#10149)

Author: andreasjordan

public/Get-DbaUserPermission.ps1

@@ -254,12 +254,13 @@ function Get-DbaUserPermission {
 
             try {
                 Write-Message -Level Verbose -Message "Removing STIG schema if it still exists from previous run"
-                $tempdb.ExecuteNonQuery($removeStigSQL)
+                # We use Invoke-DbaQuery (here and later in the code) because using ExecuteNonQuery with long batches causes problems on AppVeyor.
+                $null = Invoke-DbaQuery -SqlInstance $server -Database tempdb -Query $removeStigSQL -EnableException
                 Write-Message -Level Verbose -Message "Creating STIG schema customized for master database"
                 $createStigSQL = $sql.Replace("<TARGETDB>", 'master')
-                $tempdb.ExecuteNonQuery($createStigSQL)
+                $null = Invoke-DbaQuery -SqlInstance $server -Database tempdb -Query $createStigSQL -EnableException
                 Write-Message -Level Verbose -Message "Building data table for server objects"
-                $serverDT = $tempdb.Query($serverSQL)
+                $serverDT = Invoke-DbaQuery -SqlInstance $server -Database tempdb -Query $serverSQL -EnableException
                 foreach ($row in $serverDT) {
                     [PSCustomObject]@{
                         ComputerName       = $server.ComputerName
@@ -294,13 +295,13 @@ function Get-DbaUserPermission {
 
                 try {
                     Write-Message -Level Verbose -Message "Removing STIG schema if it still exists from previous run"
-                    $tempdb.ExecuteNonQuery($removeStigSQL)
+                    $null = Invoke-DbaQuery -SqlInstance $server -Database tempdb -Query $removeStigSQL -EnableException
                     Write-Message -Level Verbose -Message "Creating STIG schema customized for current database"
                     $createStigSQL = $sql.Replace("<TARGETDB>", $db.Name)
                     Write-Message -Level Verbose -Message "Length of createStigSQL: $($createStigSQL.Length)"
-                    $tempdb.ExecuteNonQuery($createStigSQL)
+                    $null = Invoke-DbaQuery -SqlInstance $server -Database tempdb -Query $createStigSQL -EnableException
                     Write-Message -Level Verbose -Message "Building data table for database objects"
-                    $dbDT = $db.Query($dbSQL)
+                    $dbDT = Invoke-DbaQuery -SqlInstance $server -Database $db.Name -Query $dbSQL -EnableException
                     foreach ($row in $dbDT) {
                         [PSCustomObject]@{
                             ComputerName       = $server.ComputerName
@@ -326,8 +327,12 @@ function Get-DbaUserPermission {
                 }
             }
 
-            Write-Message -Level Verbose -Message "Removing STIG schema from tempdb"
-            $tempdb.ExecuteNonQuery($removeStigSQL)
+            try {
+                Write-Message -Level Verbose -Message "Removing STIG schema from tempdb"
+                $null = Invoke-DbaQuery -SqlInstance $server -Database tempdb -Query $removeStigSQL -EnableException
+            } catch {
+                Stop-Function -Message "Failed to remove STIG schema from tempdb on $instance" -ErrorRecord $_ -Target $instance -Continue
+            }
         }
     }
 }

public/Install-DbaDarlingData.ps1

@@ -232,9 +232,8 @@ function Install-DbaDarlingData {
                     }
                     if ($Pscmdlet.ShouldProcess($instance, "installing/updating $scriptName in $database")) {
                         try {
-                            foreach ($query in ($sql -Split "\nGO\b")) {
-                                $null = $db.Query($query)
-                            }
+                            # We use Invoke-DbaQuery because using ExecuteNonQuery with long batches causes problems on AppVeyor.
+                            $null = Invoke-DbaQuery -SqlInstance $server -Database $Database -Query $sql -EnableException
                         } catch {
                             Write-Message -Level Warning -Message "Could not execute at least one portion of $scriptName in $Database on $instance." -ErrorRecord $_
                             $scriptError = $true

public/Install-DbaMaintenanceSolution.ps1

@@ -544,9 +544,8 @@ function Install-DbaMaintenanceSolution {
                         Write-ProgressHelper -ExcludePercent -Message "Installing $shortFileName"
                         $sql = $fileContents[$file]
                         try {
-                            foreach ($query in ($sql -Split "\nGO\b")) {
-                                $null = $db.Invoke($query)
-                            }
+                            # We use Invoke-DbaQuery because using ExecuteNonQuery with long batches causes problems on AppVeyor.
+                            $null = Invoke-DbaQuery -SqlInstance $server -Database $Database -Query $sql -EnableException
                         } catch {
                             $result = "Failed"
                             Stop-Function -Message "Could not execute $shortFileName in $Database on $instance" -ErrorRecord $_ -Target $db -Continue
@@ -807,7 +806,7 @@ function Install-DbaMaintenanceSolution {
                 }
             }
 
-            if ($query) {
+            if ($sql) {
                 # then whatif wasn't passed
                 [PSCustomObject]@{
                     ComputerName = $server.ComputerName

public/Install-DbaWhoIsActive.ps1

@@ -143,7 +143,6 @@ function Install-DbaWhoIsActive {
 
             $sql = [IO.File]::ReadAllText($sqlfile)
             $sql = $sql -replace 'USE master', ''
-            $batches = $sql -split "GO\r\n"
 
             $matchString = 'Who Is Active? v'
 
@@ -187,12 +186,11 @@ function Install-DbaWhoIsActive {
 
                     if ($server.Databases[$Database]) {
                         $ProcedureExists = ($server.Query($ProcedureExists_Query, $Database)).proc_count
-                        foreach ($batch in $batches) {
-                            try {
-                                $null = $server.databases[$Database].ExecuteNonQuery($batch)
-                            } catch {
-                                Stop-Function -Message "Failed to install stored procedure." -ErrorRecord $_ -Continue -Target $instance
-                            }
+                        try {
+                            # We use Invoke-DbaQuery because using ExecuteNonQuery with long batches causes problems on AppVeyor.
+                            $null = Invoke-DbaQuery -SqlInstance $server -Database $Database -Query $sql -EnableException
+                        } catch {
+                            Stop-Function -Message "Failed to install stored procedure." -ErrorRecord $_ -Continue -Target $instance
                         }
 
                         if ($ProcedureExists -gt 0) {