Skip to content

Commit 0d0ee70

Browse files
author
psainics
committed
Improve error handling for bucket access in StorageClient
1 parent a2d98a4 commit 0d0ee70

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

src/main/java/io/cdap/plugin/gcp/gcs/StorageClient.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -153,15 +153,9 @@ public void createBucketIfNotExists(GCSPath path, @Nullable String location, @Nu
153153
return;
154154
}
155155
} catch (StorageException e) {
156-
int errorCode = e.getCode();
157-
if (errorCode == 403) {
158-
LOG.warn(
159-
"Getting 403 Forbidden: {} You may not have permission to access bucket {}. Attempting to create bucket.",
160-
e.getMessage(), path.getUri());
161-
} else {
162-
LOG.warn("Getting unexpected error code {}: {} when checking if bucket {} exists. Attempting to create bucket.",
163-
errorCode, e.getMessage(), path.getBucket());
164-
}
156+
// do not throw error if unable to access bucket for backward compatibility.
157+
LOG.warn("Getting unexpected error code {}: {} when checking if bucket {} exists. Attempting to create bucket.",
158+
e.getCode(), e.getMessage(), path.getBucket());
165159
}
166160
// Fallback to bucket creations when get returns null or throws exception.
167161
try {

0 commit comments

Comments
 (0)