Skip to content

Commit 4dd4cd4

Browse files
author
Bhooshan Mogal
committed
Update documentation and widgets for MySQL and SQLServer sources
1 parent 5986606 commit 4dd4cd4

5 files changed

Lines changed: 24 additions & 19 deletions

File tree

mysql-delta-plugins/docs/mysql-cdcSource.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ slave that is replicating from the server.
6565

6666
**Password:** Password to use to connect to the MySQL server.
6767

68-
**Database:** Database to consume events for.
68+
**Database:** Database to replicate data from.
6969

70-
**JDBC Plugin Name:** Name of the jdbc driver to use.
70+
**JDBC Plugin Name:** Identifier for the MySQL JDBC driver, which is the name used while uploading the MySQL JDBC driver.
7171

7272
Troubleshooting
7373
-----------
@@ -85,4 +85,4 @@ common starting from MySQL 8 on up. To fix this, run the following command:
8585
ALTER USER '[user]'@'[host]' IDENTIFIED WITH mysql_native_password BY '[password]'
8686
```
8787

88-
to change the user to use a mysql native password.
88+
to change the user to use a MySQL native password.

mysql-delta-plugins/src/main/java/io/cdap/delta/mysql/MySqlConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ public class MySqlConfig extends PluginConfig {
4545
"this supplied consumer id.")
4646
private int consumerID;
4747

48-
@Description("Database to consume events for.")
48+
@Description("Database to replicate data from.")
4949
private String database;
5050

5151
@Nullable
5252
@Description("Timezone of the MySQL server. This is used when converting dates into timestamps.")
5353
private String serverTimezone;
5454

55-
@Description("Name of the jdbc plugin to use.")
55+
@Description("Identifier for the MySQL JDBC driver, which is the name used while uploading the MySQL JDBC driver.")
5656
private String jdbcPluginName;
5757

5858
public MySqlConfig(String host, int port, String user, String password, int consumerID,

mysql-delta-plugins/widgets/mysql-cdcSource.json

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,6 @@
2525
"label": "Consumer ID",
2626
"widget-type": "textbox"
2727
},
28-
{
29-
"name": "serverTimezone",
30-
"label": "Server Timezone",
31-
"widget-type": "textbox",
32-
"widget-attributes": {
33-
"default": "UTC"
34-
}
35-
},
3628
{
3729
"name": "jdbcPluginName",
3830
"label": "JDBC Plugin Name",
@@ -49,7 +41,7 @@
4941
]
5042
},
5143
{
52-
"label": "User Account",
44+
"label": "Credentials",
5345
"properties": [
5446
{
5547
"name": "user",
@@ -62,6 +54,19 @@
6254
"widget-type": "password"
6355
}
6456
]
57+
},
58+
{
59+
"label": "Advanced",
60+
"properties": [
61+
{
62+
"name": "serverTimezone",
63+
"label": "Server Timezone",
64+
"widget-type": "textbox",
65+
"widget-attributes": {
66+
"default": "UTC"
67+
}
68+
}
69+
]
6570
}
6671
],
6772
"outputs": []

sqlserver-delta-plugins/docs/sqlserver-cdcSource.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Hub.
5757

5858
Plugin Properties
5959
-----------
60-
**Host:** Hostname of the SQL server to read from.
60+
**Host:** Hostname or IP address of the SQL server to read from.
6161

6262
**Port:** Port to use to connect to the SQL server.
6363

@@ -67,6 +67,6 @@ Plugin Properties
6767

6868
**Password:** Password to use to connect to the SQL server.
6969

70-
**Database:** Database to consume events for.
70+
**Database:** Database to replicate data from.
7171

72-
**JDBC Plugin Name:** Name of the jdbc driver to use.
72+
**JDBC Plugin Name:** Identifier for the SQLServer JDBC driver, which is the name used while uploading the SQLServer JDBC driver.

sqlserver-delta-plugins/src/main/java/io/cdap/delta/sqlserver/SqlServerConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ public class SqlServerConfig extends PluginConfig {
4040
@Description("Password to use to connect to the SqlServer.")
4141
private String password;
4242

43-
@Description("Database to consume events for.")
43+
@Description("Database to replicate data from.")
4444
private String database;
4545

4646
@Nullable
4747
@Description("Timezone of the SqlServer. This is used when converting dates into timestamps.")
4848
private String serverTimezone;
4949

50-
@Description("Name of the jdbc plugin to use.")
50+
@Description("Identifier for the SQLServer JDBC driver, which is the name used while uploading the SQLServer JDBC driver.")
5151
private String jdbcPluginName;
5252

5353
public SqlServerConfig(String host, int port, String user, String password,

0 commit comments

Comments
 (0)