Merge pull request #117 from data-integrations/fix/sql_server_describe_table_override

sagarkapare · web-flow · commit 373357537259 · 2020-12-15T20:54:46.000-08:00
Override the describeTable method with schema parameter for SQL server source.
diff --git a/sqlserver-delta-plugins/src/main/java/io/cdap/delta/sqlserver/SqlServerTableRegistry.java b/sqlserver-delta-plugins/src/main/java/io/cdap/delta/sqlserver/SqlServerTableRegistry.java
@@ -98,6 +98,13 @@ public TableList listTables() throws IOException {
     }
   }
 
+  @Override
+  public TableDetail describeTable(String database, String schema, String table)
+    throws TableNotFoundException, IOException {
+    // TODO CDAP-17477 Ignore schema currently since its fetch from metadata in sql server
+    return describeTable(database, table);
+  }
+
   @Override
   public TableDetail describeTable(String db, String table) throws TableNotFoundException, IOException {
     try (Connection connection = DriverManager.getConnection(jdbcUrl)) {

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,13 @@ public TableList listTables() throws IOException {`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
	`101`	`+ @Override`
	`102`	`+ public TableDetail describeTable(String database, String schema, String table)`
	`103`	`+ throws TableNotFoundException, IOException {`
	`104`	`+ // TODO CDAP-17477 Ignore schema currently since its fetch from metadata in sql server`
	`105`	`+ return describeTable(database, table);`
	`106`	`+ }`
	`107`	`+`
`101`	`108`	`@Override`
`102`	`109`	`public TableDetail describeTable(String db, String table) throws TableNotFoundException, IOException {`
`103`	`110`	`try (Connection connection = DriverManager.getConnection(jdbcUrl)) {`