Retouch's color picker not working

[TurboGit]

On the retouch module, using the mode "fill color" the color picker does not work. After selecting a color on the image the corresponding color is not set as fill color.

[ralfbrown]

Near as I can tell from some quick experiments, the color shown in the retouch module after using the color picker is correct at that point in the pixelpipe. If you disable all modules after retouch which affect color or brightness, you'll get a match.

Trying to reflect the color/brightness adjustments of post-retouch modules in the fill color display will be difficult....

[jenshannoschwalm]

What i see here: filling the shape with the picked color is working as intended. Clearly wrong is the color in the "fill color rectangle"

[TurboGit]

What i see here: filling the shape with the picked color is working as intended. Clearly wrong is the color in the "fill color rectangle"

Exactly ! Same on my side, I should have been clearer.

[jenshannoschwalm]

I spotted the wrong code this morning, likely fixable for 5.2.1 give me a day or two

[jenshannoschwalm]

@TurboGit and @ralfbrown @dterrahe i think this is a far more complicated story, confessing i never touched this part of the code before, neither inspecting code or using the "Fill color" at all.

Using the picker seems to work perfectly after all my testing so far.

But:

1. Filling by a color chosen from the box does not fill by the correct color. To try use "white" to be filled and you will end up with some yellowish.
2. As described in the title, after using the picker the box does not have the "filling" color.
3. The above holds with raw files, not when using on non-raws like pngs.

While testing and looking through the code it seems to me

1. We just insert the RGB channel data from the selected color in gtk_color_chooser. We don't care about the color space we are in at all.
2. When setting the color from the picker, it's like above.

When looking through history it seems, this has been the case since introducing the module. I think - if we want to support this feature - we have to do it the hard way as we do for the pickers. That's basically the same problem there.

[TurboGit]

@jenshannoschwalm

I think - if we want to support this feature - we have to do it the hard way as we do for the pickers. That's basically the same problem there.

Can you give more hint as to what should be done here?

[jenshannoschwalm]

Can you give more hint as to what should be done here?

Sure. It's all about the color as you see it in Fill color

and Select Fill color

both are not color managed according to the colorspace we have while processing retouch but represent an RGB color as in "application colorspace".

So what is happening and what must be fixed?

1. When selecting a color via Select Fill color that RGB color must be translated to pipe colorspace before it is applied. Otherwise - as we have it now - it somewhat works but the filled color is not exactly as in the shown and selected Select Fill color
2. Whenever we update the visualized color for Fill color - just one example would be to use the picker (here we get the rgb data as we have it in retouch module colorspace as it's an in-module picker) - we must translate from pipe colorspace to "application colorspace"