[Backport release-1.17] Fix workflow list MongoDB fallback (#1622)

* Fix workflow list MongoDB fallback (#1608)

* Fix workflow list MongoDB fallback

The CLI's direct MongoDB fallback (used when gRPC ListInstanceIDs is
unavailable) searched for a "key" field, but the Dapr MongoDB state
store stores document keys in the "_id" field. This caused
`dapr workflow list -c 'mongodb://...'` to always return empty results.

Signed-off-by: joshvanl <me@joshvanl.dev>

* Review comments

Signed-off-by: joshvanl <me@joshvanl.dev>

* Review comments

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
(cherry picked from commit 2d53a10)
Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>

* Fix version test race condition

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>

Author: dapr-bot

pkg/version/version_test.go

@@ -15,6 +15,7 @@ package version
 
 import (
 	"fmt"
+	"net"
 	"net/http"
 	"testing"
 	"time"
@@ -209,7 +210,7 @@ func TestGetVersionsGithub(t *testing.T) {
 		},
 	}
 	m := http.NewServeMux()
-	s := http.Server{Addr: ":12345", Handler: m, ReadHeaderTimeout: time.Duration(5) * time.Second}
+	s := http.Server{Handler: m, ReadHeaderTimeout: time.Duration(5) * time.Second}
 
 	for _, tc := range tests {
 		body := tc.ResponseBody
@@ -218,13 +219,19 @@ func TestGetVersionsGithub(t *testing.T) {
 		})
 	}
 
+	ln, err := net.Listen("tcp", "127.0.0.1:0")
+	if err != nil {
+		t.Fatalf("failed to listen: %v", err)
+	}
+	baseURL := fmt.Sprintf("http://%s", ln.Addr().String())
+
 	go func() {
-		s.ListenAndServe()
+		s.Serve(ln)
 	}()
 
 	for _, tc := range tests {
 		t.Run(tc.Name, func(t *testing.T) {
-			version, err := GetLatestReleaseGithub("http://localhost:12345" + tc.Path)
+			version, err := GetLatestReleaseGithub(baseURL + tc.Path)
 			assert.Equal(t, tc.ExpectedVer, version)
 			if tc.ExpectedErr != "" {
 				assert.EqualError(t, err, tc.ExpectedErr)
@@ -233,9 +240,9 @@ func TestGetVersionsGithub(t *testing.T) {
 	}
 
 	t.Run("error on 404", func(t *testing.T) {
-		version, err := GetLatestReleaseGithub("http://localhost:12345/non-existant/path")
+		version, err := GetLatestReleaseGithub(baseURL + "/non-existant/path")
 		assert.Equal(t, "", version)
-		assert.EqualError(t, err, "http://localhost:12345/non-existant/path - 404 Not Found")
+		assert.EqualError(t, err, baseURL+"/non-existant/path - 404 Not Found")
 	})
 
 	t.Run("error on bad addr", func(t *testing.T) {
@@ -318,7 +325,7 @@ entries:
 		},
 	}
 	m := http.NewServeMux()
-	s := http.Server{Addr: ":12346", Handler: m, ReadHeaderTimeout: time.Duration(5) * time.Second}
+	s := http.Server{Handler: m, ReadHeaderTimeout: time.Duration(5) * time.Second}
 
 	for _, tc := range tests {
 		body := tc.ResponseBody
@@ -327,13 +334,19 @@ entries:
 		})
 	}
 
+	ln, err := net.Listen("tcp", "127.0.0.1:0")
+	if err != nil {
+		t.Fatalf("failed to listen: %v", err)
+	}
+	baseURL := fmt.Sprintf("http://%s", ln.Addr().String())
+
 	go func() {
-		s.ListenAndServe()
+		s.Serve(ln)
 	}()
 
 	for _, tc := range tests {
 		t.Run(tc.Name, func(t *testing.T) {
-			version, err := GetLatestReleaseHelmChart("http://localhost:12346" + tc.Path)
+			version, err := GetLatestReleaseHelmChart(baseURL + tc.Path)
 			assert.Equal(t, tc.ExpectedVer, version)
 			if tc.ExpectedErr != "" {
 				assert.EqualError(t, err, tc.ExpectedErr)

pkg/workflow/db/mongo.go

@@ -47,13 +47,13 @@ func ListMongo(ctx context.Context, db *mongo.Database, collection string, opts
 	regex := fmt.Sprintf("^%s.*%s$", prefix, suffix)
 
 	filter := bson.M{
-		"key": bson.M{
+		"_id": bson.M{
 			"$regex":   regex,
 			"$options": "",
 		},
 	}
 
-	findOpts := options.Find().SetProjection(bson.M{"_id": 0, "key": 1})
+	findOpts := options.Find().SetProjection(bson.M{"_id": 1})
 
 	cur, err := coll.Find(ctx, filter, findOpts)
 	if err != nil {
@@ -64,7 +64,7 @@ func ListMongo(ctx context.Context, db *mongo.Database, collection string, opts
 	var keys []string
 	for cur.Next(ctx) {
 		var doc struct {
-			Key string `bson:"key"`
+			Key string `bson:"_id"`
 		}
 		if err := cur.Decode(&doc); err != nil {
 			return nil, err

pkg/workflow/db/mongo_test.go

@@ -0,0 +1,91 @@
+/*
+Copyright 2026 The Dapr Authors
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package db
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"go.mongodb.org/mongo-driver/bson"
+	"go.mongodb.org/mongo-driver/mongo/integration/mtest"
+)
+
+const testCollection = "daprCollection"
+
+func TestListMongo(t *testing.T) {
+	mt := mtest.New(t, mtest.NewOptions().ClientType(mtest.Mock))
+
+	mt.Run("returns keys from _id field", func(mt *mtest.T) {
+		key1 := "myapp||dapr.internal.default.myapp.workflow||instance-1||metadata"
+		key2 := "myapp||dapr.internal.default.myapp.workflow||instance-2||metadata"
+
+		ns := mt.DB.Name() + "." + testCollection
+		mt.AddMockResponses(mtest.CreateCursorResponse(1, ns, mtest.FirstBatch,
+			bson.D{{Key: "_id", Value: key1}},
+		), mtest.CreateCursorResponse(0, ns, mtest.NextBatch,
+			bson.D{{Key: "_id", Value: key2}},
+		))
+
+		keys, err := ListMongo(mt.Context(), mt.DB, testCollection, ListOptions{
+			Namespace: "default",
+			AppID:     "myapp",
+		})
+		require.NoError(mt, err)
+		assert.Equal(mt, []string{key1, key2}, keys)
+	})
+
+	mt.Run("returns nil when no documents match", func(mt *mtest.T) {
+		ns := mt.DB.Name() + "." + testCollection
+		mt.AddMockResponses(mtest.CreateCursorResponse(0, ns, mtest.FirstBatch))
+
+		keys, err := ListMongo(mt.Context(), mt.DB, testCollection, ListOptions{
+			Namespace: "default",
+			AppID:     "myapp",
+		})
+		require.NoError(mt, err)
+		assert.Nil(mt, keys)
+	})
+
+	mt.Run("filter uses _id field with correct regex", func(mt *mtest.T) {
+		ns := mt.DB.Name() + "." + testCollection
+		mt.AddMockResponses(mtest.CreateCursorResponse(0, ns, mtest.FirstBatch))
+
+		_, err := ListMongo(mt.Context(), mt.DB, testCollection, ListOptions{
+			Namespace: "default",
+			AppID:     "myapp",
+		})
+		require.NoError(mt, err)
+
+		// Verify the find command was sent with _id filter.
+		cmd := mt.GetStartedEvent().Command
+		filterVal := cmd.Lookup("filter")
+		filterDoc := filterVal.Document()
+
+		// The filter should contain an "_id" field, not "key".
+		idVal, err := filterDoc.LookupErr("_id")
+		assert.NoError(mt, err, "filter should query on _id field")
+		_, err = filterDoc.LookupErr("key")
+		assert.Error(mt, err, "filter should not query on key field")
+
+		// Verify the $regex value matches the expected workflow metadata pattern.
+		idDoc := idVal.Document()
+		regexVal, err := idDoc.LookupErr("$regex")
+		require.NoError(mt, err, "filter on _id should use $regex")
+		assert.Equal(mt,
+			`^myapp\|\|dapr\.internal\.default\.myapp\.workflow\|\|.*\|\|metadata$`,
+			regexVal.StringValue(),
+		)
+	})
+}