chore: Fix old clippy issues

Author: ovr

src/ast/mod.rs

@@ -1572,7 +1572,7 @@ impl fmt::Display for Statement {
                             key_value
                                 .value
                                 .iter()
-                                .map(|value| format!("{} = {}", key_value.key, value.to_string()))
+                                .map(|value| format!("{} = {}", key_value.key, value))
                                 .collect::<Vec<String>>()
                                 .join(", ")
                         )
@@ -1605,7 +1605,7 @@ impl fmt::Display for Statement {
             Statement::ShowVariables { filter } => {
                 write!(f, "SHOW VARIABLES")?;
                 if filter.is_some() {
-                    write!(f, " {}", filter.as_ref().unwrap().to_string())?;
+                    write!(f, " {}", filter.as_ref().unwrap())?;
                 }
                 Ok(())
             }

src/ast/value.rs

@@ -94,9 +94,7 @@ impl fmt::Display for Value {
                 write!(
                     f,
                     "INTERVAL '{}' SECOND ({}, {})",
-                    value.to_string(),
-                    leading_precision,
-                    fractional_seconds_precision
+                    value, leading_precision, fractional_seconds_precision
                 )
             }
             Value::Interval {
@@ -106,7 +104,7 @@ impl fmt::Display for Value {
                 last_field,
                 fractional_seconds_precision,
             } => {
-                write!(f, "INTERVAL {}", value.to_string())?;
+                write!(f, "INTERVAL {}", value)?;
 
                 if let Some(leading_field) = leading_field {
                     write!(f, " {}", leading_field)?;

tests/sqlparser_mysql.rs

@@ -222,6 +222,11 @@ fn parse_set_transaction() {
 
 #[test]
 fn parse_set_variables() {
+    #[cfg(feature = "bigdecimal")]
+    let value = Expr::Value(Value::Number(bigdecimal::BigDecimal::from(1_i64), false));
+    #[cfg(not(feature = "bigdecimal"))]
+    let value = Expr::Value(Value::Number("1".into(), false));
+
     assert_eq!(
         mysql_and_generic().verified_stmt("SET autocommit = 1, sql_mode = 'test'"),
         Statement::SetVariable {
@@ -230,7 +235,7 @@ fn parse_set_variables() {
                     local: false,
                     hivevar: false,
                     key: "autocommit".into(),
-                    value: vec![Expr::Value(Value::Number("1".into(), false))],
+                    value: vec![value.clone()],
                 },
                 SetVariableKeyValue {
                     local: false,
@@ -252,7 +257,7 @@ fn parse_set_variables() {
                 local: true,
                 hivevar: false,
                 key: "autocommit".into(),
-                value: vec![Expr::Value(Value::Number("1".into(), false))],
+                value: vec![value],
             },]
             .to_vec()
         }

tests/sqlparser_postgres.rs

@@ -805,14 +805,20 @@ fn parse_set() {
     );
 
     let stmt = pg_and_generic().verified_stmt("SET a = 0");
+
+    #[cfg(feature = "bigdecimal")]
+    let value = Expr::Value(Value::Number(bigdecimal::BigDecimal::from(0_i64), false));
+    #[cfg(not(feature = "bigdecimal"))]
+    let value = Expr::Value(Value::Number("0".into(), false));
+
     assert_eq!(
         stmt,
         Statement::SetVariable {
             key_values: [SetVariableKeyValue {
                 local: false,
                 hivevar: false,
                 key: "a".into(),
-                value: vec![Expr::Value(Value::Number("0".into(), false))],
+                value: vec![value],
             }]
             .to_vec()
         }