Skip to content

Commit 107f339

Browse files
authored
feat(cubeshared): Upgrade flatbuffers to 25.12.19 (#10709)
Bump flatbuffers from 23.1.21 to 25.12.19, regenerate http_message bindings, and re-export the crate as `cubeshared::flatbuffers` so downstream consumers (cubestore) depend on a single version. Add wire-format compatibility tests in cubeshared/tests/wire_compat.rs that deserialize fixtures produced by the previous flatbuffers version to guard against accidental wire-format regressions.
1 parent b6e5886 commit 107f339

21 files changed

Lines changed: 519 additions & 334 deletions

File tree

packages/cubejs-backend-native/Cargo.lock

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/cubeorchestrator/Cargo.lock

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/cubeorchestrator/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ serde_json = "1.0.133"
1111
anyhow = "1.0"
1212
itertools = "0.13.0"
1313
indexmap = { version = "2.0", features = ["serde"] }
14-
flatbuffers = "23.5.26"
1514

1615
[dependencies.neon]
1716
version = "=1"

rust/cubeorchestrator/src/query_message_parser.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use crate::{
33
transport::JsRawData,
44
};
55
use cubeshared::codegen::{root_as_http_message_with_opts, HttpCommand};
6-
use flatbuffers::VerifierOptions;
6+
use cubeshared::flatbuffers::VerifierOptions;
77
use indexmap::IndexMap;
88
use neon::prelude::Finalize;
99

@@ -158,7 +158,7 @@ mod tests {
158158
root_as_http_message_unchecked, HttpColumnValue, HttpColumnValueArgs, HttpCommand,
159159
HttpMessage, HttpMessageArgs, HttpResultSet, HttpResultSetArgs, HttpRow, HttpRowArgs,
160160
};
161-
use flatbuffers::FlatBufferBuilder;
161+
use cubeshared::flatbuffers::FlatBufferBuilder;
162162

163163
/// Helper function to create a test HttpMessage with a given number of rows and columns
164164
fn create_test_message(num_rows: usize, num_columns: usize) -> Vec<u8> {
@@ -320,7 +320,7 @@ mod tests {
320320
#[test]
321321
fn test_parse_with_custom_verifier_options() {
322322
use cubeshared::codegen::root_as_http_message_with_opts;
323-
use flatbuffers::VerifierOptions;
323+
use cubeshared::flatbuffers::VerifierOptions;
324324

325325
// Test that custom verifier options can handle large datasets
326326
let msg_data = create_test_message(33_000, 40);

rust/cubeshared/Cargo.lock

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/cubeshared/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ version = "0.1.0"
44
edition = "2021"
55

66
[dependencies]
7-
flatbuffers = "23.1.21"
7+
flatbuffers = "25.12.19"

0 commit comments

Comments
 (0)